← Back to issue list

lifecycle: emit progress for packing

View original Github issue

Metadata

Project
craft-application
Number
#52
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged into main. Adds progress emission during packing to prevent a long ticker on the Lifecycle finished message. Approved by two reviewers, passed CI, and modified two files with two added lines.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- This avoids a long ticker on the message that the Lifecycle finished execution

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into main. Adds progress emission during packing to prevent a long ticker on the Lifecycle finished message. Approved by two reviewers, passed CI, and modified two files with two added lines.
qwen3.6-35b-a3b-mtp-q6 Merged to main. The update emits progress signals during the packing phase to eliminate a lingering ticker upon Lifecycle completion. Codecov verified 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#103 fix: use progress for the packing messages craft-application merged Merged fix replacing the appending Packing message with a progress indicator that overwrites previous output. Approved by two reviewers, passed CI, and achieved 100% diff coverage across seven changed files.
77%
#810 feat(lifecycle): only pack files if not already packed craft-application merged Merged a lifecycle optimization that skips redundant file packing by verifying existing pack lists, prime timestamps, and file integrity. Approved by three reviewers and passed CI checks, successfully integrating the change.
76%
#4461 fix: improve lifecycle messages snapcraft merged Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage.
75%
#121 fix: don't duplicate lifecycle progress messages craft-application merged Merged into main following two approvals and passing CI. The change prevents duplicate lifecycle progress messages across three files. Code coverage remains at 99.01% with 100% diff coverage.
73%
#4431 feat: improve lifecycle messages snapcraft merged Merged into main following approval from two reviewers and passing CI checks. The change improves lifecycle messages across six files (+61/-54 lines) with 87.50% diff coverage.
71%
#726 Show lifecycle step progress (and related fix for always getting the instance logs). charmcraft merged Merged changes adding lifecycle step progress display and fixing instance log capture on success and error. Uses Emitter.pause() to ensure logs are always captured. Consolidates output messages and improves zip file logging. Approved and passed CI checks.
70%
#265 lifecycle_manager: minor primed packages sort refactoring craft-parts merged Merged a minor refactoring to fix list sorting in lifecycle_manager after debug instrumentation was removed. Approved by one reviewer, passed CI checks, and applied with a +1/-3 line change.
70%