← Back to issue list

feat(ProjectService): make the ProjectService compatible with multi-base

View original Github issue

Metadata

Project
craft-application
Number
#812
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-application#812 as commit c4bf6b4c, adding opt-in multi-base support and errors for unsupported apps; shipped in 5.5.0.

Resolution: closed resolved

Reason: PR #812 was approved with all CI checks passing and merged as commit c4bf6b4c. The 5.5.0 changelog confirms the ProjectService multi-base compatibility change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This modifies the ProjectService such that it's compatible with multi-base platforms definitions. AppMetadata gets a flag to register whether the app supports multi-base platforms (defaulting to False). If a user uses multi-base platforms when an app doesn't support it, they get an error message to that effect. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#812 as commit c4bf6b4c, adding opt-in multi-base support and errors for unsupported apps; shipped in 5.5.0.
stealth/space-bunny-alpha — closed resolved Merged #812: made ProjectService multi-base compatible and added an AppMetadata support flag, defaulting to False with an error for unsupported apps.
qwen/qwen3.6-35b-a3b — — Merged update making ProjectService compatible with multi-base platforms. Adds an AppMetadata flag to validate support and errors if unsupported. Approved by two reviewers, passed CI checks, and merged 370 days ago.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#569 Allow multi-base builds craft-application closed Multi-base build plans were enabled by merged PR #598 (d81c39a7), explicitly fixing #569; PR #812 (c4bf6b4c) later added ProjectService compatibility for 5.5.0.
75%
#2646 fix(Project): fix shorthand multi-base notation charmcraft merged Merged as 9dbd59a6, updating craft-platforms to fix craft-application 6 multi-base shorthand notation and adding regression coverage; fixes charmcraft#2620.
73%
#598 feat: allow for multi-base builds craft-application merged Merged as d81c39a7; allowed bases in platform entries so applications can implement multi-base build plans, fixing #569 (CRAFT-3719).
70%