← Back to issue list

fix(pack): put a gate around skipping repack.

View original Github issue

Metadata

Project
craft-application
Number
#829
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix that adds a gate around skipping repack. Approved by three reviewers and passed all CI checks. The change modifies five files with 21 additions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix that adds a gate around skipping repack. Approved by three reviewers and passed all CI checks. The change modifies five files with 21 additions.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that adds a conditional gate to prevent incorrectly skipping the repack step. The change passed all lint and test checks, was authored by maintainer lengau, and integrated directly without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1565 cli: add the pack command snapcraft merged Merged the pack CLI command, replacing the previous assemble implementation. Approved by one reviewer, passed CI checks, and updated seven files with 164 additions and 16 deletions.
75%
#103 fix: use progress for the packing messages craft-application merged Merged fix replacing the appending Packing message with a progress indicator that overwrites previous output. Approved by two reviewers, passed CI, and achieved 100% diff coverage across seven changed files.
73%
#1060 pack: add recursive bundle packing charmcraft merged Added recursive bundle packing to the pack module. Merged after approval and addressing reviewer feedback. Changes span 10 files with 750 additions and 32 deletions.
72%
#61 fix(package service): change signature for pack craft-application merged Merged into main. Changes the pack function signature to defer option loading, preventing premature initialization. Approved by two reviewers, passed CI checks, and maintained 100% coverage.
70%
#926 Made pack & upload tests more robust. charmcraft merged Merged changes that improve pack and upload test reliability by removing reliance on the last revision, preventing race conditions with concurrent test uploads. Approved by one reviewer, modifying three files with 31 additions and 21 deletions.
70%