← Back to issue list

Redesign fetch-service integration with provider instances

View original Github issue

Metadata

Project
craft-application
Number
#839
Type
issue
State
closed
Author
tigarmo
Labels
Status: Triaged
Created
Updated
Closed

Current evaluation

Closed as stale after prolonged inactivity; no fix or superseding implementation was documented. PR #837 was the incomplete precursor, while #849 added early instance proxy configuration.

Resolution: closed stale

Reason: The issue was closed without a resolving commit, replacement item, or maintainer explanation; its only comment was an automated CRAFT-4679 Jira notification. PR #849 addressed early proxy setup but there is no evidence it closed #839 or completed every external-session requirement.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done With PR #837 we have non-working support for fetch-service sessions that are externally managed. The things that keep us from "fully" supporting it are: - Today the fetch-service session handling is done *after* the LXD instance is created and setup, but we need to do some configuring on the instance *during* its setup. This includes things like doing a full apt-update and pushing&installing the fetch-service certificate. This is not something that craft-providers supports today. - Since these instances will have a random certificate installed, we need to fully isolate them from non-fetch-service builds. This means *not* using a base instance, and fully cleaning a pre-existing one (build must be "from scratch" each time). Another point here is that if we're going to support this case - using the fetch-service *during* instance setup - we should use it in the existing "managed" fetch-service "mode" too. This simplifies the code (only a single path) and makes both "modes" closer to each other. The `fetch-service-external` spread test from #837 can be used to valid implementations, as it's currently a "strict xfail" because of these limitations. ### Why it needs to get done Without this we cannot support external sessions.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed as stale after prolonged inactivity; no fix or superseding implementation was documented. PR #837 was the incomplete precursor, while #849 added early instance proxy configuration.
stealth/space-bunny-alpha — closed stale Closed as stale after prolonged inactivity; no implementation or superseding item was documented, and the sole update was an automated link to internal ticket CRAFT-4679.
qwen/qwen3.6-35b-a3b — — Closed without a GitHub fix. Automatically synced to Jira ticket CRAFT-4679, indicating the redesign was deferred or handled externally.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The redesign was moved to internal tracking via Jira ticket CRAFT-4679. No code changes or merges were made, indicating the feature was deferred.
qwen/qwen3.6-35b-a3b — — Closed without implementation or resolution. The issue details required redesigns for externally managed fetch-service sessions and instance isolation but shows no follow-up commits, PRs, or resolution notes.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#837 (confidence 100%)

    Introduced the incomplete external fetch-service session support and strict xfail described by #839.

  • Likely Fixed By: craft-application#849 (confidence 80%)

    Commit 093817ee added early proxy configuration during instance setup, addressing part of the requested redesign.

Related issues

No related issues found above the similarity threshold.