← Back to issue list

feat: "support" existing fetch-service sessions

View original Github issue

Metadata

Project
craft-application
Number
#837
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged incremental changes adding CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables for external fetch-service sessions. Approved by reviewers and passing CI, this serves as a foundational step toward full external session management.

Suggested action:

No scores available.

Issue body

This commit does "half" of the work needed to support packing with pre-existing sessions that are managed by someone else. It introduces support for the CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables and adds a spread test exposing the current issue: we must configure fetch-service items early in a managed instance's lifetime. As such, the feature is not ready for use but this changeset is a step in the direction of completeness. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged incremental changes adding CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables for external fetch-service sessions. Approved by reviewers and passing CI, this serves as a foundational step toward full external session management.
qwen3.6-35b-a3b-mtp-q6 Merged initial implementation adding CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables for external fetch-service sessions. Includes a spread test. Feature remains incomplete and not production-ready.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#480 feat: support per-session inspector conf fetch-service merged Merged: Added per-session inspector configuration support. Approved by two reviewers and passed all CI checks. Proceeded despite 14 unresolved comments and a known spread test failure from an external store bug. Closes FETCH-31.
72%
#272 feat: add fetch-service version to session metadata fetch-service merged Merged after approval from two reviewers and passing CI. Introduces a generator key to session metadata to explicitly track the fetch-service version, resolving issue #258.
72%
#490 feat: allow strict/permissive fetch-service sessions craft-application merged Merged after approval and CI checks, adding mandatory strict or permissive session arguments to the --use-fetch-service flag. Resolves issue #487.
72%
#456 feat: add fetch-service integration craft-application merged Merged fetch-service integration into the craft tool build. Changes span 18 files with 1445 additions and 32 deletions. Approved by two reviewers after individual commit reviews.
72%