feat: "support" existing fetch-service sessions
Metadata
Current evaluation
Merged in craft-application#837 as d03d8b43, adding external fetch-service and proxy-certificate environment support as groundwork; the PR explicitly delivered only partial packing support.
Resolution: closed resolved
Reason: Pull request #837 was approved and merged as commit d03d8b43, so its proposed incremental changes landed. The author noted that full pre-existing-session packing support remained unfinished.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This commit does "half" of the work needed to support packing with pre-existing sessions that are managed by someone else. It introduces support for the CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables and adds a spread test exposing the current issue: we must configure fetch-service items early in a managed instance's lifetime.
As such, the feature is not ready for use but this changeset is a step in the direction of completeness.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-application#837 as d03d8b43, adding external fetch-service and proxy-certificate environment support as groundwork; the PR explicitly delivered only partial packing support. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-application#837 (d03d8b43), adding external fetch-service and proxy-certificate environment support as an incremental step; full pre-existing session packing remained unfinished. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #837 as d03d8b43, adding foundational CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT support for externally managed fetch-service sessions; complete support remained follow-up work. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged incremental changes adding CRAFT_USE_EXTERNAL_FETCH_SERVICE and CRAFT_PROXY_CERT environment variables for external fetch-service sessions. Approved by reviewers and passing CI, this serves as a foundational step toward full external session management. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#1181
(confidence 90%)
Later merged work extended external fetch-service session support to the test command.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #490 feat: allow strict/permissive fetch-service sessions | craft-application | merged | Merged PR #490 as d327e604, requiring --use-fetch-service to select strict or permissive sessions and fixing craft-application#487. | |
| #1199 feat: support CRAFT_TEST_FETCH_SERVICE_SESSIONS | craft-application | merged | Merged PR #1199 (commit e2f9f3ba) adds CRAFT_TEST_FETCH_SERVICE_SESSIONS so tests use a fetch-service session URL instead of HTTP_PROXY; shipped in craft-application 7.5.0 with docs, unit and spread tests. | |
| #456 feat: add fetch-service integration | craft-application | merged | Merged in PR #456, adding fetch-service lifecycle, sessions, certificates, build-instance configuration, and environment integration across 18 files. | |
| #1181 feat(test): support fetch-service sessions in 'test' | craft-application | closed | PR #1181 by tigarmo was merged (commit ca7ec04c), adding CRAFT_USE_EXTERNAL_FETCH_SERVICE support to 'craft test' so spread execution proxies runner traffic (apt/snapd) through a fetch-service session. All CI checks passed. | |
| #272 feat: add fetch-service version to session metadata | fetch-service | merged | Merged PR #272 added a generator field with the fetch-service version to session metadata, resolving fetch-service#258; merged as commit a0e826f. |