fix(check_supported_base): ESM still counts as EOL
Metadata
Current evaluation
Merged #886 via commit 1c64a59c, fixing base checks so extended-support releases still count as EOL; tests and changelog were updated.
Resolution: closed resolved
Reason: PR #886 was merged with all reported CI checks passing. Commit 1c64a59c implements the ESM end-of-life handling and accompanying tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Modify ``check_base_is_supported`` so bases that are in extended support still count as EOL.
CRAFT-4705
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #886 via commit 1c64a59c, fixing base checks so extended-support releases still count as EOL; tests and changelog were updated. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix updated supported-base detection so bases in extended support still count as EOL, with tests and changelog updates. All reported CI checks passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #886 (commit 1c64a59c), fixing check_base_is_supported so bases in extended support still count as EOL. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix to check_base_is_supported that correctly classifies extended support bases as EOL. Approved by two reviewers with all CI checks passing. Maintainer bypassed a pending review to unblock related work. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #946 test: check EOL bases on a *real* EOL base! | craft-application | merged | Merged PR #946 as caed282d, adding test coverage for EOL-base handling on an actual end-of-life base. |