fix(check_supported_base): ESM still counts as EOL
Metadata
Current evaluation
Merged fix to check_base_is_supported that correctly classifies extended support bases as EOL. Approved by two reviewers with all CI checks passing. Maintainer bypassed a pending review to unblock related work.
Suggested action: —
No scores available.
Issue body
Modify ``check_base_is_supported`` so bases that are in extended support still count as EOL.
CRAFT-4705
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix to check_base_is_supported that correctly classifies extended support bases as EOL. Approved by two reviewers with all CI checks passing. Maintainer bypassed a pending review to unblock related work. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix to check_base_is_supported ensuring extended support bases are treated as EOL. Maintainer lengau bypassed review to unblock CRAFT-4706, with formal review deferred to release. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #850 feat: add check for unsupported bases | craft-application | merged | Merged a feature implementing a check for unsupported bases, introducing the --allow-unsupported-base flag to bypass restrictions. Approved by three reviewers with all CI checks passing. | |
| #946 test: check EOL bases on a *real* EOL base! | craft-application | merged | Merged test changes verifying EOL bases on a real EOL base. Approved by two reviewers, passed all CI checks, and modified 7 files with 78 additions and 30 deletions. | |
| #1153 fix(project): handle devel bases in is_effective_base_eol() | craft-application | merged | Merged fix for is_effective_base_eol() crash on devel or unrecognized bases. Now treats devel as never EOL and catches unknown errors, matching sibling methods. Includes unit tests and passed review. |