← Back to issue list

test: check EOL bases on a *real* EOL base!

View original Github issue

Metadata

Project
craft-application
Number
#946
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #946 as caed282d, adding test coverage for EOL-base handling on an actual end-of-life base.

Resolution: closed resolved

Reason: PR #946 was approved and merged as commit caed282d, with all reported CI checks passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #946 as caed282d, adding test coverage for EOL-base handling on an actual end-of-life base.
stealth/space-bunny-alpha — closed resolved Merged PR #946 in commit caed282d, adding test coverage that validates EOL-base handling on an actually end-of-life base.
qwen/qwen3.6-35b-a3b — — Merged test changes verifying EOL bases on a real EOL base. Approved by two reviewers, passed all CI checks, and modified 7 files with 78 additions and 30 deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1153 fix(project): handle devel bases in is_effective_base_eol() craft-application merged Merged PR #1153 as commit 9c757100, fixing #1152: devel and unknown bases are now handled safely in is_effective_base_eol(), with regression tests.
74%
#886 fix(check_supported_base): ESM still counts as EOL craft-application merged Merged #886 via commit 1c64a59c, fixing base checks so extended-support releases still count as EOL; tests and changelog were updated.
70%