← Back to issue list

test: check EOL bases on a *real* EOL base!

View original Github issue

Metadata

Project
craft-application
Number
#946
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged test changes verifying EOL bases on a real EOL base. Approved by two reviewers, passed all CI checks, and modified 7 files with 78 additions and 30 deletions.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test changes verifying EOL bases on a real EOL base. Approved by two reviewers, passed all CI checks, and modified 7 files with 78 additions and 30 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged a test update to validate EOL base detection using an actual end-of-life release instead of a simulated one. Improves test accuracy for release lifecycle checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1153 fix(project): handle devel bases in is_effective_base_eol() craft-application merged Merged fix for is_effective_base_eol() crash on devel or unrecognized bases. Now treats devel as never EOL and catches unknown errors, matching sibling methods. Includes unit tests and passed review.
74%
#886 fix(check_supported_base): ESM still counts as EOL craft-application merged Merged fix to check_base_is_supported that correctly classifies extended support bases as EOL. Approved by two reviewers with all CI checks passing. Maintainer bypassed a pending review to unblock related work.
71%