← Back to issue list

feat(linter): add linter service framework

View original Github issue

Metadata

Project
craft-application
Number
#907
Type
pull request
State
merged
Author
HamdaanAliQuatil
Labels
Created
Updated
Closed

Current evaluation

Merged a shared Linter Service framework for craft-application, enabling consistent linting across downstream apps. Approved by three reviewers, passed all CI checks, and closed issue #782.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Closes #782 This PR introduces a shared Linter Service to craft-application so downstream apps (Snapcraft, Charmcraft) can add and run linters consistently. The design of the Linter Service is as discussed in #782

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a shared Linter Service framework for craft-application, enabling consistent linting across downstream apps. Approved by three reviewers, passed all CI checks, and closed issue #782.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces a shared Linter Service framework to craft-application for consistent downstream linting. Addressed reviewer feedback, passed CI and documentation checks, and successfully closed issue #782.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2546 Use Craft Application's Linter Service charmcraft open Refactor to migrate charmcraft's linters to craft-application's shared LinterService for consistent lint UX across craft apps. Triaged and open; upstream framework (craft-application#907) is merged, but no code changes yet and no human activity for ~7 months.
79%
#5971 Use Craft Application's Linter Service snapcraft open Refactor to migrate snapcraft linters to craft-application's LinterService. Triaged and labeled; upstream framework (craft-application#907) is merged, but no code changes yet. Supersedes closed #5542.
78%
#141 Add a basic linter service craft-application closed Closed without implementation. The proposal to build a shared extensible linter service was deferred to internal Jira ticket CRAFT-2602 and subsequently abandoned.
74%
#5542 Use Craft Application's Linter Service snapcraft closed Abandoned without implementation. Migrating linters to the Craft Application LinterService was blocked by the upstream dependency, and the associated $400 bounty was closed.
73%
#1746 fix(linters): fix Framework linter crash charmcraft merged Merged a fix for the Framework linter crash, resolving issue #1715. The single-file change added 16 lines and removed 9, approved by two reviewers, and passed CI checks.
73%
#2315 Use Craft Application's Linter Service charmcraft closed The bounty for migrating to the Craft Application Linter Service was closed, abandoning the issue. Implementation remained blocked by upstream dependency resolution, and no code changes were merged.
71%