← Back to issue list

fix(launchpad): don't skip proxies

View original Github issue

Metadata

Project
craft-application
Number
#913
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #913 as commit 71652477, adding PySocks to remote dependencies so Launchpad no longer skips proxy configurations.

Resolution: closed resolved

Reason: PR #913 was merged into main as commit 71652477. It adds pysocks>=1.7.1 to the remote dependencies, resolving launchpadlib/httplib2 skipping proxies when SOCKS support is unavailable.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #913 as commit 71652477, adding PySocks to remote dependencies so Launchpad no longer skips proxy configurations.
stealth/space-bunny-alpha — closed resolved Merged a Launchpad fix so proxies are no longer skipped. All listed CI checks passed, and three reviewers approved the 19-line change.
qwen/qwen3.6-35b-a3b — — Merged a fix for the launchpad module that prevents proxies from being skipped. Approved by three reviewers and passing all CI checks, the change modifies three files with 19 additions before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5785 fix(launchpad): don't bypass proxy environment variables snapcraft merged Merged PR #5785 fixed Launchpad requests to honor configured proxy environment variables; merged as commit 178f86b7a.
79%