← Back to issue list

fix(launchpad): don't bypass proxy environment variables

View original Github issue

Metadata

Project
snapcraft
Number
#5785
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5785 fixed Launchpad requests to honor configured proxy environment variables; merged as commit 178f86b7a.

Resolution: closed resolved

Reason: PR #5785 was approved by two reviewers and merged. Commit 178f86b7a contains the proxy-handling fix.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5785 fixed Launchpad requests to honor configured proxy environment variables; merged as commit 178f86b7a.
stealth/space-bunny-alpha — closed resolved Launchpad now respects configured proxy environment variables instead of bypassing them. The fix was merged after approval by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged a fix preventing the launchpad integration from bypassing proxy environment variables. Approved by two reviewers and integrated after passing core CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring the launchpad integration respects proxy environment variables instead of bypassing them. Authored by maintainer lengau, the change passed all linting and testing checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#913 fix(launchpad): don't skip proxies craft-application merged Merged PR #913 as commit 71652477, adding PySocks to remote dependencies so Launchpad no longer skips proxy configurations.
79%