← Back to issue list

docs: fix indentation

View original Github issue

Metadata

Project
craft-application
Number
#919
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

PR #919 (commit d569dccf) merged into craft-application, fixing a 2-line docs indentation mistake introduced by review feedback in #912; all CI checks passed.

Resolution: closed resolved

Reason: The PR was merged as commit d569dccf ("docs: fix indentation (#919)") with 2 approvals and no unresolved review comments, correcting the indentation regression that the maintainer's review of #912 had accidentally suggested.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- Fixes an indentation issue that I accidentally suggested in my review of https://github.com/canonical/craft-application/pull/912.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #919 (commit d569dccf) merged into craft-application, fixing a 2-line docs indentation mistake introduced by review feedback in #912; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #919 (commit d569dccf) fixed a two-line documentation indentation mistake introduced by review feedback on merged PR #912. Docs-only, +2/-2 lines, all CI checks passed and approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #919 (commit d569dccf) corrected two lines of documentation indentation, fixing review feedback accidentally introduced in #912. All CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged documentation fix correcting an indentation error introduced in a prior review. Approved by two reviewers, passed all CI checks, and applied a minimal two-line change.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#912 (confidence 95%)

    PR #912 (commit 554d9a9e, AppCommand.get_project convenience method) is where the indentation mistake was introduced; #919 corrects it.

Related issues

Issue Project State Summary Similarity
#17 ci: update docs CI craft-application merged Merged in craft-application#17 via commit f71a2aec, updating docs CI to fix Sphinx linting failures; remaining lint/test CI fixes were handled in #18.
77%
#1165 docs: address minor spellchecking issues craft-parts merged Merged docs PR #1165 by maintainer tigarmo (commit 0168fb06) fixed two minor spelling mistakes in craft-parts documentation (+2/-1 across 2 files); approved by 2 reviewers with all CI checks passing.
74%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed.
72%
#167 style: fix docstring line breaks craft-platforms merged Merged PR #167 as commit 97a9041, correcting a docstring line break that caused the documentation CI task to fail; all reported checks passed.
71%
#1200 fix: indent multiline examples correctly craft-parts merged Merged craft-parts#1200 to fix indentation in multiline documentation examples, landing as commit 5d64bd57 after feedback in canonical/rockcraft#933.
71%
#2299 docs: fix formatting issues charmcraft merged Merged docs formatting fixes for local documentation builds in charmcraft#2299 via commit 5ffb80fe; two files changed (+3/-1).
70%
#822 docs: Release 5.6.0 craft-application merged Release documentation PR for craft-application 5.6.0 was merged (commit b1ceac95), updating docs/reference/changelog.rst with the 2025-07-24 release notes. Approved by 3 reviewers, all CI checks passing.
70%
#856 style: update mypy and fix linting issues craft-application merged Merged in canonical/craft-application#856 (177c2cc4), updating mypy and fixing linting issues; all listed CI checks passed.
70%
#1197 docs: align `CONTRIBUTING.md` with template craft-parts merged Merged docs-only PR #1197 (commit 41cbe718) aligning CONTRIBUTING.md with the craft project template, +147/-89 lines; follow-up to earlier CONTRIBUTING work in #1134/#1142.
70%