← Back to issue list

style: update mypy and fix linting issues

View original Github issue

Metadata

Project
craft-application
Number
#856
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/craft-application#856 (177c2cc4), updating mypy and fixing linting issues; all listed CI checks passed.

Resolution: closed resolved

Reason: PR #856 was merged as commit 177c2cc4 after approval by two reviewers. It updated mypy and corrected linting issues, with every listed CI check passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#856 (177c2cc4), updating mypy and fixing linting issues; all listed CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #856 (commit 177c2cc4) updated mypy and fixed linting issues in two files; all listed CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#856 (commit 177c2cc4), updating mypy and fixing linting issues across two files; two reviewers approved it and all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#901 style: fix ruff 0.13 linting issues craft-application merged Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed.
74%
#740 style: update type checkers craft-providers merged Merged in craft-providers#740 via 9e4c518, updating mypy and switching type checking to the Pyright snap.
72%
#404 build(deps): update dependency mypy to v1.19.0 (main) craft-cli merged Renovate PR canonical/craft-cli#404 merged into main via commit d890e38, updating mypy from 1.18.2 to 1.19.0 after two approvals and all CI checks passed.
72%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
72%
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged in canonical/craft-parts#90 (commit 23f38957), resolving CRAFT-364 by fixing or suppressing new mypy and pylint warnings.
71%
#486 docs: fixed broken references craft-parts merged Merged as canonical/craft-parts#486 via commit fd734825, correcting broken documentation references in four files; rebasing onto main cleared a Pydantic 2-related mypy failure.
70%
#136 build(deps): update dependency mypy to ~=1.18.1 craft-grammar merged Renovate PR canonical/craft-grammar#136 merged to main (commit 1752f36), bumping mypy from ~=1.17.0 to ~=1.18.1 in pyproject.toml/uv.lock; approved by 2 reviewers with all CI checks green.
70%
#17 ci: update docs CI craft-application merged Merged in craft-application#17 via commit f71a2aec, updating docs CI to fix Sphinx linting failures; remaining lint/test CI fixes were handled in #18.
70%
#919 docs: fix indentation craft-application merged PR #919 (commit d569dccf) merged into craft-application, fixing a 2-line docs indentation mistake introduced by review feedback in #912; all CI checks passed.
70%