← Back to issue list

style: update mypy and fix linting issues

View original Github issue

Metadata

Project
craft-application
Number
#856
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged after updating mypy and resolving linting issues. The maintainer verified all checks passed and integrated the changes into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6034 style: fix mypy warnings snapcraft merged Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch.
84%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
82%
#421 style: drop mypy, pyright craft-store merged Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
80%
#2816 assorted: address errors from mypy uprev snapcraft merged Merged a pull request addressing mypy errors from an upgrade. The maintainer combined remaining fixes into one PR, which was approved by two reviewers and passed CI. Changes affect 15 files with 65 additions and 45 deletions.
79%
#90 many: address new linter warnings (CRAFT-364) craft-parts merged Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines).
78%
#958 build(deps): update dependency mypy to ~=1.14.1 craft-parts merged Merged automated dependency update raising mypy from ~=1.11.0 to ~=1.14.1. Approved by two reviewers, passed CI checks, and applied to two files with 34 additions and 25 deletions.
78%
#57 tests: update pylint and address new warnings craft-parts merged Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file.
78%
#6 tools: Configure mypy starbase merged Configuring mypy was approved by one reviewer and successfully merged. The update modified two files, adding 30 lines and removing 1, to establish type checking in the project tools.
77%
#176 build(deps): update dependency mypy to ~=1.20.0 craft-grammar merged Merged after updating the mypy dependency to version 1.20.0, replacing PR #174. Approved by three reviewers with CI checks passing. The change modifies six files to implement the dependency update.
76%
#2807 meta: address errors from mypy uprev snapcraft merged Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files.
76%