← Back to issue list

The `adopt_info` field should be checked to reference a valid part.

View original Github issue

Metadata

Project
craft-application
Number
#926
Type
issue
State
open
Author
lengau
Labels
Status: Triaged Type: Bug
Created
Updated
Closed
—

Current evaluation

Adopt-info still accepts nonexistent part names; the exact parts: {} reproducer remains valid after an earlier validation fix was reverted.

Suggested action: keep open

Reason: Project.adopt_info remains an unconstrained optional string, so no model validation rejects a name absent from the parts dictionary. The issue is maintainer-authored and marked Triaged; PR #227 implemented validation but commit 12685e8e reverted it, leaving a valid cross-field-validation bug open.

Evaluated by: mr-cal-bot

Impact: 45 Quick Win: 25 Complexity: 38 Confidence: 96 Actionability: 90

Issue body

### Bug Description Right now the `adopt-info` field accepts any string, whether it's a part in the project or not. ### To Reproduce Use testcraft to build the file below. ### part yaml ```shell name: minimal-valid-project parts: {} version: "0.0" adopt-info: my-part platforms: amd64: build-on: [amd64] build-for: [amd64] ``` ### Relevant log output ```shell n/a ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 45
Quick Win: 25
Complexity: 38
Confidence: 96
Actionability: 90
keep open Adopt-info still accepts nonexistent part names; the exact parts: {} reproducer remains valid after an earlier validation fix was reverted.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 14
Complexity: 40
Confidence: 70
Actionability: 80
keep open The adopt_info field accepts any string without validating it references an existing part in the parts dictionary. A previous fix attempt was reverted.
qwen/qwen3.8-27b
Impact: 50
Quick Win: 30
Staleness: 55
Complexity: 40
Confidence: 70
Support Request: 5
keep open Bug: the adopt-info field accepts any string without verifying it references an existing part in the project. Triaged by a maintainer (lengau) with a Jira ticket (CRAFT-4818) created, but no fix has landed; the field is still a plain str with no validator in the current code.
qwen/qwen3.6-35b-a3b
Staleness: 75
Complexity: 15
Confidence: 85
Support Request: 5
keep open adopt-info field accepts any string instead of validating it references an existing part. Currently triaged and awaiting implementation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 78
Complexity: 20
Confidence: 85
Support Request: 0
keep open Validates that the adopt-info field references an existing part. Currently accepts any string. Triaged as a bug, but inactive for ~9 months with no maintainer follow-up.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#227 (confidence 98%)

    Commit ba401238 fixed adopt-info validation by name, but commit 12685e8e reverted that implementation.

Related issues

No related issues found above the similarity threshold.