← Back to issue list

fix(models): address adopt-info validation by name

View original Github issue

Metadata

Project
craft-application
Number
#227
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #227 merged as ba401238, fixing adopt-info validation by name; the change was later reverted in 12685e8e, and related support was reintroduced by #231.

Resolution: closed resolved

Reason: The approved PR was merged in ba401238 with a unit test, correcting Pydantic 1.x validation to use the project name rather than the file alias. Commit 12685e8e later reverted the model fix, while related adoptable-variable support returned in #231 at a7bb9839.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Pydantic 1.x seemingly root-validates using both file alias and name, leading to inconsistent behavior. This should address the issue for now, but the issue warrants further investigation. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #227 merged as ba401238, fixing adopt-info validation by name; the change was later reverted in 12685e8e, and related support was reintroduced by #231.
stealth/space-bunny-alpha — closed resolved PR #227 merged as ba401238, making adopt-info root validation use names consistently under Pydantic 1.x and adding unit tests; later reverted by 12685e8e.
qwen/qwen3.6-35b-a3b — — Merged a temporary fix for Pydantic 1.x validation inconsistency in adopt-info by name and alias. The change adds requested unit tests, passes CI checks, and resolves the immediate root-validation behavior issue.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#217 (confidence 98%)

    Introduced adoptable project-variable support whose validation behavior #227 corrected.

  • Related To: canonical/craft-application#231 (confidence 95%)

    Reintroduced related adoptable-variable support after the earlier implementation and #227 fix were reverted.

Related issues

No related issues found above the similarity threshold.