← Back to issue list

fix(models): address adopt-info validation by name

View original Github issue

Metadata

Project
craft-application
Number
#227
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged a temporary fix for Pydantic 1.x validation inconsistency in adopt-info by name and alias. The change adds requested unit tests, passes CI checks, and resolves the immediate root-validation behavior issue.

Suggested action:

No scores available.

Issue body

Pydantic 1.x seemingly root-validates using both file alias and name, leading to inconsistent behavior. This should address the issue for now, but the issue warrants further investigation. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a temporary fix for Pydantic 1.x validation inconsistency in adopt-info by name and alias. The change adds requested unit tests, passes CI checks, and resolves the immediate root-validation behavior issue.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for Pydantic 1.x validation inconsistency in adopt-info by name. A unit test was added following reviewer feedback. The change resolves the immediate validation issue, with further investigation noted.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.