feat: support "--destructive-mode".
Metadata
Current evaluation
Merged PR #93 (commit c0dd21a3) added --destructive-mode support to all lifecycle commands, including pack and clean, closing issue #57; maintainer confirmed it also re-enabled a disabled rockcraft spread test.
Resolution: closed resolved
Reason: PR #93 was merged into main as commit c0dd21a3 with 2 approving reviews, implementing --destructive-mode across lifecycle commands and fixing issue #57. Maintainer tigarmo confirmed on 2023-10-05 that it fixed the disabled rockcraft spread test, and the flag is present in craft_application/commands/lifecycle.py today.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This affects all lifecycle commands, including pack and clean.
Fixes #57
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #93 (commit c0dd21a3) added --destructive-mode support to all lifecycle commands, including pack and clean, closing issue #57; maintainer confirmed it also re-enabled a disabled rockcraft spread test. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #93 (commit c0dd21a3) merged to add --destructive-mode to all lifecycle commands (pack, clean, etc.), closing #57. Maintainer confirmed it unblocked a disabled rockcraft spread test. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #93 (c0dd21a3) added --destructive-mode to all lifecycle commands, including pack and clean, fixing #57. The maintainer confirmed it also fixed a disabled rockcraft spread test. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Implements --destructive-mode across all lifecycle commands, fixing issue #57 and a disabled rockcraft spread test. Approved by two reviewers, passed CI with 100% diff coverage, and changed three files. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#57
(confidence 95%)
Issue #57 'Add "destructive" mode' is the feature request explicitly fixed by this PR, which is now closed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #227 cli: add --destructive-mode flag | rockcraft | merged | Merged PR #227 as commit 84f76b85, adding --destructive-mode so ROCKs can be built directly on the host, matching Snapcraft and Charmcraft. | |
| #441 commands/pack: add --destructive-mode support (CRAFT-358) | charmcraft | merged | Merged PR #441 via commit 874e2f8a, adding --destructive-mode to pack, Builder.run() handling, and a reusable project-builder fixture. | |
| #57 Add "destructive" mode | craft-application | closed | Added support for --destructive-mode in commit c0dd21a3, delivering the requested in-host build feature parity. | |
| #93 commands: add clean command | rockcraft | merged | Merged as c4502a7a via PR #93, adding the rockcraft clean command scaffold with TODO paths for part, destructive-mode, and provider cleanup. |