feat: support "--destructive-mode".
Metadata
Current evaluation
Merged. Implements --destructive-mode across all lifecycle commands, fixing issue #57 and a disabled rockcraft spread test. Approved by two reviewers, passed CI with 100% diff coverage, and changed three files.
Suggested action: —
No scores available.
Issue body
This affects all lifecycle commands, including pack and clean.
Fixes #57
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Implements --destructive-mode across all lifecycle commands, fixing issue #57 and a disabled rockcraft spread test. Approved by two reviewers, passed CI with 100% diff coverage, and changed three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main, adding --destructive-mode support to lifecycle commands like pack and clean. Resolves issue #57 and fixes a disabled rockcraft spread test. Achieved 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #227 cli: add --destructive-mode flag | rockcraft | merged | Merged the addition of a --destructive-mode CLI flag enabling direct host-based ROCK builds, similar to Snapcraft and Charmcraft. Approved by two reviewers, modifying six files with 104 additions and 8 deletions. | |
| #869 feat: add 'test' command | rockcraft | merged | Merged. Added the 'test' CLI command and spread tests for rockcraft. Approved by two reviewers, passed CI checks, and introduced 276 lines across seven files to validate the command using hardcoded fixtures. | |
| #2577 cli: Add --destructive-mode to clean | snapcraft | merged | Merged into master, adding --destructive-mode to the clean CLI command to allow wrapper scripts to pass the flag to lifecycle commands. Approved by two reviewers, the change was merged with 100% diff coverage and a 0.02% overall coverage increase. | |
| #441 commands/pack: add --destructive-mode support (CRAFT-358) | charmcraft | merged | Merged after approval. Adds --destructive-mode to the pack command, updating Builder.run() for consistent destructive builds. Includes a reusable project builder fixture and refactors packaging logic. | |
| #1288 feat: support stonking as a devel base | rockcraft | merged | Merged. Adds stonking as a valid development base for Rockcraft. Approved by three reviewers. CI spread test failures were caused by an external chisel bug and did not prevent the merge. | |
| #57 feat(rockcraft): support --ignore=unmaintained | craft-actions | merged | Merged following approval from three reviewers and successful CI checks. Introduces the --ignore=unmaintained flag to rockcraft, resolving issue #52. The update modifies 9 files with 179 additions and 17 deletions. |