commands/pack: add --destructive-mode support (CRAFT-358)
Metadata
Current evaluation
Merged PR #441 via commit 874e2f8a, adding --destructive-mode to pack, Builder.run() handling, and a reusable project-builder fixture.
Resolution: closed resolved
Reason: PR #441 was merged in commit 1a45b3a6, with implementation commit 874e2f8a adding destructive-mode support for the pack command.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Add --destructive-mode bool parameter to pack command.
- Add basic_project_builder fixture for reusable project building
code to help reduce further duplication.
- Update Builder.run() with parameter to indicate whether or not
to build in destructive-mode. Use it when determining how to
appropriate build/pack charm(s). Behavior is consistent with
managed-mode.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #441 via commit 874e2f8a, adding --destructive-mode to pack, Builder.run() handling, and a reusable project-builder fixture. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #441 in commit 874e2f8a, adding pack --destructive-mode support, Builder.run() handling, and a reusable project builder fixture. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #441 (commit 874e2f8a; merge 1a45b3a6), adding --destructive-mode to pack, updating Builder.run(), and adding a reusable project-builder fixture. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Adds --destructive-mode to the pack command, updating Builder.run() for consistent destructive builds. Includes a reusable project builder fixture and refactors packaging logic. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged, adding --destructive-mode support to the pack command. The update modifies Builder.run() and introduces a reusable project builder fixture. Reviewers noted test file renaming and future migration of build logic to the pack module for follow-up. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #93 feat: support "--destructive-mode". | craft-application | merged | Merged PR #93 (commit c0dd21a3) added --destructive-mode support to all lifecycle commands, including pack and clean, closing issue #57; maintainer confirmed it also re-enabled a disabled rockcraft spread test. | |
| #57 Add "destructive" mode | craft-application | closed | Added support for --destructive-mode in commit c0dd21a3, delivering the requested in-host build feature parity. | |
| #1791201 add support for --destructive-mode | snapcraft (launchpad) | closed | Host builds via --destructive-mode landed in merged PR canonical/snapcraft#2339 (commit 024c63453), making Multipass default while retaining host builds. |