Move repack-test directory creation to prepare phase
Metadata
Current evaluation
Merged the repack-test setup fix in #964, moving directory creation to prepare so restore cleanup still works when execute fails.
Resolution: closed resolved
Reason: PR #964 was merged and moved `mkdir repack-test` from execute into prepare, ensuring the directory exists before restore uses pushd.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Addresses feedback from #944 to prevent `restore` phase failures when `execute` fails before creating the working directory.
## Changes
- Move `mkdir repack-test` from `execute` to new `prepare` phase in `tests/spread/testcraft/skip-repack/task.yaml`
- `prepare` phase runs before both `execute` and `restore`, ensuring directory exists for cleanup via `pushd`
<!-- START COPILOT CODING AGENT TIPS -->
---
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged the repack-test setup fix in #964, moving directory creation to prepare so restore cleanup still works when execute fails. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#964, moving repack-test directory creation to prepare so restore cleanup can run after early execute failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Relocated repack-test directory creation from the execute to the prepare phase in the test task. This guarantees the directory exists prior to cleanup, resolving restore phase failures triggered by early execute failures. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#944
(confidence 98%)
This change incorporated the related spread-test speedup work from #944 and resolved its feedback.
Related issues
No related issues found above the similarity threshold.