test(spread): speed up the skip-retest spread test
Metadata
Current evaluation
PR #944 was closed unmerged and superseded by craft-application#964, which carried the spread-test speedup changes forward and merged the adjusted repack-test setup.
Resolution: closed superseded
Reason: #944 was closed without merging after its changes were moved to canonical/craft-application#964. The replacement PR was merged and moved repack-test directory creation to the prepare phase.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Don't restart the container between pack runs and do the clean during restore.
I found this while I was doing some unrelated work on the spread tests.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #944 was closed unmerged and superseded by craft-application#964, which carried the spread-test speedup changes forward and merged the adjusted repack-test setup. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #964, where the skip-retest spread-test speedups were moved for continued review and implementation; #944 was closed without merging. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #964, which was merged to move repack-test directory creation into the prepare phase, allowing restore cleanup after early execute failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #964. The changes to optimize the skip-retest spread test by avoiding container restarts between pack runs were moved to the new PR for review and implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by pull request #964. The test optimization changes were continued in the new PR to address unresolved review comments. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
90
Complexity:
15
Confidence:
95
|
close stale | Speeds up skip-retest spread test by deferring cleanup. Inactive for 7+ months and explicitly superseded by PR #964. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
15
Confidence:
95
|
close stale | Optimizes skip-retest spread test by avoiding container restarts between pack runs. Superseded by PR #964 and inactive for 215 days. |
Update history
| Date | Change |
|---|---|
| closed |
Related work
-
Superseded By:
canonical/craft-application#964
(confidence 99%)
Replacement PR for the skip-retest spread-test changes; it merged the adjusted test setup.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5418 ci: speed up spread test suite | snapcraft | merged | Merged PR #5418 (commit a5682c276, SNAPCRAFT-353) sped up the spread test suite from 1h40m to 40m: split slow tests into a manually triggered workflow, used wheels, added store retries, fixed the matter test. Fixes #5296. | |
| #16 tests: add spread support | rockcraft | merged | Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a). | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files. | |
| #109 tests: add testcraft fake application and spread tests | craft-application | closed | Closed as a duplicate of canonical/craft-application#97; the fake testcraft app and spread tests were delivered by merged PR #666 (commit 621d1a32). | |
| #399 test(spread): retry restore cleanup for pack tests | imagecraft | closed | PR #399 was closed unmerged after 51 days with seven unresolved review comments and one failing spread job; its restore-cleanup retry changes were not incorporated. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #1514 feat(testing): add spread testing template files | charmcraft | closed | Closed unmerged as superseded by #1660 (commit 097a4e9a), which added charmcraft test and Spread templates, plus merged follow-up #1686 (58d36668). | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files). | |
| #2774 test: speed up spread test runtime by removing redundant package setup | charmcraft | open | Removes redundant apt update calls and consolidates package installs in spread tests to reduce runtime. All CI passing, awaiting review of 1 unresolved comment. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. |