build: clean up dependency groups
Metadata
Current evaluation
Merged in craft-archives#210 as commit fbee636, removing pyright from package dependencies and making the lint group include the types group.
Resolution: closed resolved
Reason: PR #210 was approved and merged with all CI checks passing. Commit fbee636 records the completed dependency-group cleanup.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
- Removes pyright from the package dependencies, as this is installed already in the Makefile
- Includes the `types` group in the `lint` group as the latter is always going to want the former.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-archives#210 as commit fbee636, removing pyright from package dependencies and making the lint group include the types group. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged build: clean up dependency groups; removed pyright from package dependencies and made lint depend on the types group. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of dependency groups. Removed redundant pyright from package dependencies, as it is already in the Makefile. Added the types group to the lint group. Approved by two reviewers with all CI checks passing. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1298 build: remove pyright from dev dependencies | craft-parts | merged | Merged PR #1298 (commit 89c6a6eb) dropped Pyright from craft-parts dev dependencies in 2 files (-25 lines), since Pyright is already installed as a snap and the PyPI dependency caused inconsistent CI environments. | |
| #7 build(deps): update dependency pyright to v1.1.391 | craft-artifacts | merged | Renovate dependency bump of pyright from 1.1.390 to 1.1.391 in craft-artifacts; merged as commit 4270834 (PR #311) via merge commit a4c11cf. | |
| #279 build(deps): update dependency pyright to v1.1.383 | craft-cli | merged | Renovate PR #279 was merged (commit 9939a25), bumping pyright from 1.1.365 to 1.1.383 in craft-cli's lint build dependencies after approval by2 reviewers. | |
| #115 build(deps): update dependency pyright to v1.1.398 | craft-platforms | merged | Renovate PR merged: bumped pyright from 1.1.394 to 1.1.398 in craft-platforms, merged as commit b5885f5 ("build(deps): update dependency pyright to v1.1.398 (#115)"), +5/-5 lines across 2 files. | |
| #67 build(deps): update dependency pyright to v1.1.385 | craft-platforms | merged | Renovate dependency bump of pyright from 1.1.384 to 1.1.385 in craft-platforms was approved (2 reviewers) and merged to main via commit b6fb1ff, updating 2 files (+6/-6). | |
| #219 build(deps): update dependency pyright to v1.1.383 | craft-store | merged | Renovate dependency bump of pyright from 1.1.381 to 1.1.383 in craft-store; PR #219 merged via squash commit 8368145 (approved by 2 reviewers). | |
| #149 build(deps): update dependency pyright to v1.1.401 | imagecraft | merged | Renovate PR #149 bumped pyright from 1.1.400 to 1.1.401 in imagecraft's dev dependencies. Merged with 2 approvals as commit e4276a5 (2 files, +5/-5). |