← Back to issue list

build: remove pyright from dev dependencies

View original Github issue

Metadata

Project
craft-parts
Number
#1298
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1298 (commit 89c6a6eb) dropped Pyright from craft-parts dev dependencies in 2 files (-25 lines), since Pyright is already installed as a snap and the PyPI dependency caused inconsistent CI environments.

Resolution: closed resolved

Reason: The PR was merged into main by maintainer bepri with 2 approvals and all CI checks passing; commit 89c6a6eb removes the pyright entry from the dev dependencies (pyproject.toml and related dev requirements).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Pyright is already installed as a snap. Also installing it as a dev dependency causes inconsistent environments in CI.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1298 (commit 89c6a6eb) dropped Pyright from craft-parts dev dependencies in 2 files (-25 lines), since Pyright is already installed as a snap and the PyPI dependency caused inconsistent CI environments.
stealth/space-bunny-alpha — closed resolved Merged PR #1298 via commit 89c6a6eb, removing Pyright from dev dependencies to avoid inconsistent CI environments because the snap installation was already available.
qwen/qwen3.6-35b-a3b — — Merged to remove pyright from dev dependencies. Since pyright is already installed as a snap, keeping it locally caused inconsistent CI environments. The change was approved by two reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of pyright from dev dependencies. The package was dropped because it is already available as a snap, and including it as a dev dependency caused inconsistent CI environments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#327 build(deps): remove pyright starbase merged Merged PR #327 removed pyright from build dependencies in commit 4c45c0e because it is installed separately via snap or uv.
80%
#115 build(deps): update dependency pyright to v1.1.398 craft-platforms merged Renovate PR merged: bumped pyright from 1.1.394 to 1.1.398 in craft-platforms, merged as commit b5885f5 ("build(deps): update dependency pyright to v1.1.398 (#115)"), +5/-5 lines across 2 files.
78%
#149 build(deps): update dependency pyright to v1.1.401 imagecraft merged Renovate PR #149 bumped pyright from 1.1.400 to 1.1.401 in imagecraft's dev dependencies. Merged with 2 approvals as commit e4276a5 (2 files, +5/-5).
76%
#67 build(deps): update dependency pyright to v1.1.385 craft-platforms merged Renovate dependency bump of pyright from 1.1.384 to 1.1.385 in craft-platforms was approved (2 reviewers) and merged to main via commit b6fb1ff, updating 2 files (+6/-6).
76%
#7 build(deps): update dependency pyright to v1.1.391 craft-artifacts merged Renovate dependency bump of pyright from 1.1.390 to 1.1.391 in craft-artifacts; merged as commit 4270834 (PR #311) via merge commit a4c11cf.
76%
#219 build(deps): update dependency pyright to v1.1.383 craft-store merged Renovate dependency bump of pyright from 1.1.381 to 1.1.383 in craft-store; PR #219 merged via squash commit 8368145 (approved by 2 reviewers).
75%
#210 build: clean up dependency groups craft-archives merged Merged in craft-archives#210 as commit fbee636, removing pyright from package dependencies and making the lint group include the types group.
75%
#279 build(deps): update dependency pyright to v1.1.383 craft-cli merged Renovate PR #279 was merged (commit 9939a25), bumping pyright from 1.1.365 to 1.1.383 in craft-cli's lint build dependencies after approval by2 reviewers.
75%
#69 build(deps): update dependency pyright to v1.1.386 craft-platforms merged Renovate dependency bump of pyright from 1.1.385 to 1.1.386 was merged into craft-platforms (commit ab543a8), approved by 2 reviewers and merged via Renovate automerge.
74%
#68 build(deps): update dependency pyright to v1.1.388 craft-grammar merged Renovate PR #68 bumped the pyright dev dependency from ==1.1.387 to ==1.1.388 in craft-grammar's dev tooling pin and was merged (commit 5d0fd0a), later superseded by #69 (v1.1.389).
74%