← Back to issue list

move "repo" code from snapcraft

View original Github issue

Metadata

Project
craft-archives
Number
#3
Type
pull request
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3 moved snapcraft.repo into craft_archives, adapting logging, errors, utilities, tests, and linting; commits 31da2f9 through 3cb8d7c implemented it.

Resolution: closed resolved

Reason: PR canonical/craft-archives#3 was approved and merged. It transferred the repository code and tests in commits 31da2f9, c19fad6, 553932a, and 3cb8d7c, including logger, utility, error, Ruff, and Pyright updates.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR have a lot of copy/pasted and automated fixes, so I strongly suggest looking at the individual commits: 1) The first commit is a literal copy-and-paste for the `snapcraft.repo` package and the tests in `tests/unit/repo`; 2) The second commit is a find-and-replace of "snapcraft" to "craft_archives". Note that I kept used filenames like `snapcraft.gpg` unchanged because this part of the code will be changed in the near future, and changing it now would break snapcraft; 3) The third commit has actual "manual" changes. These include using loggers instead of craft_cli's `emit()`, adding a base error class and copying the `os_release` and `util` utility packages from snapcraft. 4) The final commit has changes to address linting errors, because craft-archives uses `ruff` and `pyright` in stricter settings. CRAFT-1549

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3 moved snapcraft.repo into craft_archives, adapting logging, errors, utilities, tests, and linting; commits 31da2f9 through 3cb8d7c implemented it.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/craft-archives#3, transferring snapcraft.repo and its tests to craft_archives, adopting loggers, adding shared utilities and a base error, and applying stricter lint fixes.
qwen/qwen3.6-35b-a3b — — Merged after approval, moving the snapcraft.repo package and tests to craft_archives. Updates include switching to loggers, adding a base error class, copying utility packages, and applying stricter linting fixes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4 move repo code craft-archives merged Merged PR #4, moving repository code from Snapcraft into craft-archives after approval; the recreated import landed in commit 31da2f9.
87%
#1673448 refactor repo into its own package snapcraft (launchpad) closed Tracked to GitHub PR snapcore/snapcraft#1192 "repo: refactor into a package", merged as 1e2cd8a2e, turning snapcraft.repo into a package and extending BaseRepo for non-apt/deb use. Later moved to craft-archives (#4037).
82%
#1192 repo: refactor into a package. snapcraft merged Merged as 1e2cd8a2e, refactoring snapcraft.repo into a package and making BaseRepo easier to extend for non-apt/deb functionality.
76%
#3647 repo: add package repository handling (CRAFT-846) snapcraft merged Merged package repository and PPA definitions/helpers into snapcraft 7.0 via #3647, porting code from #2911, #3341, #3359, and #3363.
73%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged PR #3579 via ed2baf8bd, moving Snapcraft's own snap to the core20 base; implementation commit 18a974e01.
70%
#12 docs: import package repositories docs from snapcraft craft-archives merged PR merged as 62ad299, importing Snapcraft package-repositories docs into craft-archives sphinx docs, plus Ubuntu font CSS, sphinx-lint, and a rundocs target (CRAFT-1551).
70%