repo: refactor into a package.
Metadata
Current evaluation
Merged as 1e2cd8a2e, refactoring snapcraft.repo into a package and making BaseRepo easier to extend for non-apt/deb functionality.
Resolution: closed resolved
Reason: PR #1192 merged into master as commit 1e2cd8a2e, delivering the approved repository-package refactor and BaseRepo extensibility improvements.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Refactoring repo into a package makes it extremely easy to add
new functionality outside of apt/deb by adding such enablement
into `__init__` and by extending `BaseRepo`.
LP: #1602258
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 1e2cd8a2e, refactoring snapcraft.repo into a package and making BaseRepo easier to extend for non-apt/deb functionality. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1192 as commit 1e2cd8a2e, refactoring repo into a package so BaseRepo can be extended for non-apt/deb functionality. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals. Refactored the repo module into a package across 41 files to simplify extending BaseRepo for external functionality. Changes were split during review, CI proxy issues were resolved, and integration completed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring repo into a package to simplify extending BaseRepo and adding non-apt/deb functionality via __init__. Scope was reduced by splitting unrelated changes into PR #1194. Approved and merged by maintainer sergiusens. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1194
(confidence 95%)
Split from this PR to remove obsolete plugin test patches after the refactor.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1673448 refactor repo into its own package | snapcraft (launchpad) | closed | Tracked to GitHub PR snapcore/snapcraft#1192 "repo: refactor into a package", merged as 1e2cd8a2e, turning snapcraft.repo into a package and extending BaseRepo for non-apt/deb use. Later moved to craft-archives (#4037). | |
| #3647 repo: add package repository handling (CRAFT-846) | snapcraft | merged | Merged package repository and PPA definitions/helpers into snapcraft 7.0 via #3647, porting code from #2911, #3341, #3359, and #3363. | |
| #3 move "repo" code from snapcraft | craft-archives | closed | Merged PR #3 moved snapcraft.repo into craft_archives, adapting logging, errors, utilities, tests, and linting; commits 31da2f9 through 3cb8d7c implemented it. | |
| #953 sources: refactor base sources into new package. | snapcraft | closed | Closed unmerged after review changes; successor PR snapcraft#957 completed the Base and FileBase extraction in commit 1d34e9e6b. | |
| #3341 repo: move apt ppa helpers into apt_ppa module | snapcraft | merged | Merged in canonical/snapcraft#3341 as commit 68ec9d3c9, extracting apt PPA helpers from _deb and expanding focused unit-test coverage. | |
| #4 move repo code | craft-archives | merged | Merged PR #4, moving repository code from Snapcraft into craft-archives after approval; the recreated import landed in commit 31da2f9. |