← Back to issue list

migrate to pyright

View original Github issue

Metadata

Project
craft-cli
Number
#147
Type
issue
State
closed
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Resolved through Ruff rather than a new Pyright migration; the maintainer closed #147 on 2023-10-09, stating the work was done when Ruff was enabled.

Resolution: closed resolved

Reason: Maintainer tigarmo closed the issue with “Done when we enabled ruff.” Commit b1b5513, “build: fixes for pyright errors uncovered by ruff,” documents the associated Ruff-enabled cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Pyright report a whole set of typing problems (typically lack of typing annotations).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Resolved through Ruff rather than a new Pyright migration; the maintainer closed #147 on 2023-10-09, stating the work was done when Ruff was enabled.
stealth/space-bunny-alpha — closed superseded Closed without a Pyright migration: maintainer tigarmo marked it done on 2023-10-09 after Ruff was enabled as the chosen linting solution.
stealth/space-bunny-alpha — closed superseded Pyright migration was replaced by Ruff; maintainer @tigarmo closed #147 on 2023-10-09, saying it was done when Ruff was enabled.
stealth/space-bunny-alpha — closed resolved Resolved by enabling Ruff instead of migrating to Pyright; the maintainer marked the issue done on 2023-10-09.
stealth/space-bunny-alpha — closed superseded Migration to Pyright was abandoned in favor of enabling Ruff, which covers the reported typing and annotation checks.
qwen/qwen3.6-35b-a3b — — The pyright migration was completed when ruff was enabled instead. The maintainer closed the issue, confirming ruff now handles type checking and annotation reporting.
qwen/qwen3.6-35b-a3b — — Superseded by enabling ruff instead. The maintainer closed the issue, confirming ruff now handles the type checking and annotation reporting originally requested for pyright.
qwen/qwen3.6-35b-a3b — — Superseded by enabling ruff, which resolved the typing checks and closed the pyright migration request.
qwen/qwen3.6-35b-a3b — — Superseded by ruff. The pyright migration was closed after the maintainer confirmed the task was completed when ruff was enabled instead. Ruff now handles type checking and linting, making the pyright migration unnecessary.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#146 migrate to `ruff` craft-cli closed Closed without a documented fix; Ruff was later enabled via #204 (commit 09b91ba), with Black replaced by Ruff formatting in #212.
70%