migrate to `ruff`
Metadata
Current evaluation
Closed without a documented fix; Ruff was later enabled via #204 (commit 09b91ba), with Black replaced by Ruff formatting in #212.
Resolution: closed stale
Reason: The issue received no comments or linked resolution and was closed before Ruff work landed. Commit 09b91ba from PR #204 later enabled the Ruff snap, while PR #212 completed the formatter migration.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Starbase uses ruff, but adding it to craft-cli brings a whole new set of type errors as ruff annotates functions that were previously un-annotated (like constructors). So this needs some separate work to enable the tool and resolve all issues.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Closed without a documented fix; Ruff was later enabled via #204 (commit 09b91ba), with Black replaced by Ruff formatting in #212. | |
| stealth/space-bunny-alpha | — | closed stale | Ruff migration was left unfinished and closed without a linked fix: the issue identified type errors from unannotated functions and required separate annotation work. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and effectively abandoned. Integrating ruff triggers type errors from unannotated functions, requiring separate refactoring work. The migration remains unaddressed. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. Adding ruff introduces type errors from unannotated functions, requiring separate refactoring. The migration was deferred and effectively abandoned due to the additional work needed. | |
| qwen/qwen3.6-35b-a3b | — | — | The ruff migration was abandoned due to the complexity of resolving new type errors from unannotated functions. The issue was closed without implementation or further discussion. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
craft-cli#204
(confidence 90%)
Commit 09b91ba enabled use of the Ruff snap.
-
Related To:
craft-cli#212
(confidence 80%)
Replaced Black formatting with Ruff format.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #439 style: migrate from black to ruff for formatting | craft-providers | closed | Ruff formatting migration was abandoned unmerged after the team considered `ruff format` too experimental. | |
| #212 style: replace black formatter with ruff format | starbase | merged | Merged PR #212 as commit aae9d00, replacing Black with Ruff format across seven files (+26/-10). | |
| #119 style: replace black with ruff formatter | craft-archives | merged | Merged PR #119 replaced Black with the Ruff formatter across 14 files (+42/-21), completing the style migration. | |
| #739 style: switch from black to ruff | craft-providers | merged | Merged #739 as commit 2b9c894, replacing Black with Ruff formatting across 23 files in preparation for Starbase adoption. | |
| #1084 build(style): switch from black to ruff | craft-parts | merged | Merged #1084 as commit b28a1dfc, replacing Black with Ruff and autoformatting 32 files; all CI checks passed. | |
| #264 lint: format with ruff and fix ruff linting errors | rockcraft | closed | Ruff formatting and lint cleanup in #264 was closed unmerged after remaining unreviewed. Prerequisite #263 merged as 4abd39c2, while later Ruff adoption continued in #363. | |
| #147 migrate to pyright | craft-cli | closed | Resolved through Ruff rather than a new Pyright migration; the maintainer closed #147 on 2023-10-09, stating the work was done when Ruff was enabled. | |
| #660 build: update ruff settings | craft-parts | closed | Ruff configuration PR was closed unmerged after prolonged inactivity; its six-line settings update was not applied. |