Discuss whether we should maintain 'line-length = 99'
Metadata
Current evaluation
Style decision on line length: repo now consistently uses 88 (ruff, isort, .editorconfig, sphinx-lint) after black removal and starbase merge; no 99 remains anywhere, so the 99-vs-88 discussion is settled.
Suggested action: close resolved
Reason: The question raised (keep 99 or align with Starbase's default) has effectively been decided and implemented: commit 1d72f49 "chore: update line length configuration (#221)" normalized the value, and e05899f "chore: prepare for starbase merge (#340)" locked in 88. Grepping the current tree confirms no 99 remains — pyproject.toml has [tool.ruff] line-length = 88 and [tool.isort] line_length = 88, .editorconfig has max_line_length = 88, and common.mk runs sphinx-lint --max-line-length 88 — so the reformatting risk the author worried about has already been absorbed and the codebase is uniform. syu-w's comment ("I am ok with 88, 99, or 100") shows the discussion converged on accepting the Starbase default. The only residual uncertainty is whether the maintainer considers the discussion formally closed, since the issue itself has no decision recorded.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
12
Quick Win:
7
Complexity:
20
Confidence:
80
Actionability:
78
|
close resolved | Style decision on line length: repo now consistently uses 88 (ruff, isort, .editorconfig, sphinx-lint) after black removal and starbase merge; no 99 remains anywhere, so the 99-vs-88 discussion is settled. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
6
Complexity:
5
Confidence:
70
Actionability:
40
|
close stale | Discussion about whether to maintain line-length = 99 (currently 88 in pyproject.toml). Discussion occurred in comments but no decision was reached. | |
| qwen/qwen3.8-27b |
Impact:
10
Quick Win:
9
Staleness:
90
Complexity:
10
Confidence:
80
Support Request:
10
|
close stale | Discussion on whether to keep line-length = 99 or align with Starbase's default of 88. Resolved in practice: the codebase now uses 88 (ruff, isort, sphinx-lint) after the starbase migration; no activity since June 2023. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
95
Complexity:
15
Confidence:
85
Support Request:
5
|
close stale | Discussion on whether to change the Python line-length configuration from 99 to 88 to align with Starbase defaults. Currently inactive with no decision or labels after over three years. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
95
Complexity:
10
Confidence:
85
Support Request:
0
|
close stale | Discussion on whether to change the Python line-length configuration from 99 to 88 to align with Starbase defaults. Open with no maintainer decision or action for over three years. |
Update history
No update history recorded yet.
Related work
-
Related To:
craft-cli#340
(confidence 88%)
Commit e05899f "chore: prepare for starbase merge (#340)" is the commit that sets the current 88 values in pyproject.toml/.editorconfig and made Starbase's default the effective answer.
-
Likely Fixed By:
craft-cli#221
(confidence 72%)
Commit 1d72f49 "chore: update line length configuration (#221)" is the only commit that touched the .editorconfig line-length setting and appears to be the decision point for this discussion.
-
Superseded By:
craft-cli#305
(confidence 70%)
Commit 4837258 "Remove black (#305)" removed the black config that carried line-length = 99, superseding the formatter the issue's 'git-black-wise' concern was framed around; grep for 'black' now returns no matches.
Related issues
No related issues found above the similarity threshold.