← Back to issue list

Discuss whether we should maintain 'line-length = 99'

View original Github issue

Metadata

Project
craft-cli
Number
#149
Type
issue
State
open
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Discussion on whether to keep line-length = 99 or align with Starbase's default of 88. Resolved in practice: the codebase now uses 88 (ruff, isort, sphinx-lint) after the starbase migration; no activity since June 2023.

Suggested action: close stale

Reason: The question has been answered by the codebase: pyproject.toml now sets [tool.ruff] line-length = 88, isort line_length = 88, and common.mk runs sphinx-lint with --max-line-length 88, matching Starbase's default. A pickaxe search shows the 'line-length = 99' string was removed in the starbase merge commit (e05899f, PR #340), so the discussion is moot and the issue is inactive for ~3.2 years.

Impact: 10 Quick Win: 9.0 Staleness: 90 Complexity: 10 Confidence: 80 Support Request: 10

Issue body

This goes against Starbase's default, but the reformatting is possibly quite noisy (git-black-wise). We could go either way, so we should discuss and make a decision.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 10
Quick Win: 9.0
Staleness: 90
Complexity: 10
Confidence: 80
Support Request: 10
close stale Discussion on whether to keep line-length = 99 or align with Starbase's default of 88. Resolved in practice: the codebase now uses 88 (ruff, isort, sphinx-lint) after the starbase migration; no activity since June 2023.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 5
close stale Discussion on whether to change the Python line-length configuration from 99 to 88 to align with Starbase defaults. Currently inactive with no decision or labels after over three years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 10
Confidence: 85
Support Request: 0
close stale Discussion on whether to change the Python line-length configuration from 99 to 88 to align with Starbase defaults. Open with no maintainer decision or action for over three years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 10
Confidence: 85
Support Request: 0
close stale Evaluates whether to maintain the line length at 99 or revert to 88 to align with black and Starbase defaults. Contributors assess reformatting noise and readability. Open for decision, inactive for over three years.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-cli#340 (confidence 70%)

    Starbase merge commit e05899f is the last commit to touch the 'line-length = 99' string; current HEAD uses 88 throughout, indicating the decision to adopt Starbase's default was made there.

Related issues

No related issues found above the similarity threshold.