The `text` parameter in `Emitter.open_stream()` should be optional
Metadata
Current evaluation
Emitter.open_stream()'s text parameter is now optional. Merged via canonical/craft-cli#194 (commit 24cf0fb), signature changed to `text: str | None = None`; issue closed by maintainer tigarmo.
Resolution: closed resolved
Reason: PR canonical/craft-cli#194 ('feat(emit): make text param in open_stream() optional') was merged into main as commit 24cf0fb after two approvals, and the maintainer closed the issue with 'Fixed by #194'. The current signature in craft_cli/messages.py is `def open_stream(self, text: str | None = None)`, confirming the change landed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
The `text` parameter in `Emitter.open_stream()` should be optional
### Why it needs to get done
With how the craft apps use the emitter now, the text is often redundant.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Emitter.open_stream()'s text parameter is now optional. Merged via canonical/craft-cli#194 (commit 24cf0fb), signature changed to `text: str | None = None`; issue closed by maintainer tigarmo. | |
| stealth/space-bunny-alpha | — | closed resolved | Resolved by merged PR #194 (commit 24cf0fb), making Emitter.open_stream()'s text parameter optional with a default of None. | |
| stealth/space-bunny-alpha | — | closed resolved | Closed as fixed: PR canonical/craft-cli#194 (commit 24cf0fb) merged to main, making Emitter.open_stream()'s text parameter default to None (now `text: str | None = None`). | |
| stealth/space-bunny-alpha | — | closed resolved | Made Emitter.open_stream()'s text parameter optional via merged craft-cli#194 (commit 24cf0fb). | |
| stealth/space-bunny-alpha | — | closed resolved | Made Emitter.open_stream()'s text parameter optional in craft-cli PR #194, merged into main via commit 24cf0fb. | |
| qwen/qwen3.6-35b-a3b | — | — | Made the text parameter in Emitter.open_stream optional to reduce redundancy in craft apps. Resolved by merging pull request #194. | |
| qwen/qwen3.6-35b-a3b | — | — | The text parameter in Emitter.open_stream() was made optional to reduce redundancy. The issue was closed after maintainer tigarmo confirmed it was fixed and merged via pull request #194. | |
| qwen/qwen3.6-35b-a3b | — | — | The text parameter in Emitter.open_stream() was made optional. The fix was merged via pull request #194, resolving the redundancy issue in craft apps and closing the request. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#194
(confidence 100%)
Merged PR implementing the change in commit 24cf0fb; cited by the closing comment.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #194 feat(emit): make text param in open_stream() optional | craft-cli | merged | Merged PR #194 as commit 24cf0fb, making Emitter.open_stream()'s text parameter optional. |