← Back to issue list

feat(emit): make text param in open_stream() optional

View original Github issue

Metadata

Project
craft-cli
Number
#194
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #194 as commit 24cf0fb, making Emitter.open_stream()'s text parameter optional.

Resolution: closed resolved

Reason: The change was approved by two reviewers and merged into main as commit 24cf0fb. The resulting API accepts text as str | None with a default of None.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #194 as commit 24cf0fb, making Emitter.open_stream()'s text parameter optional.
stealth/space-bunny-alpha — closed resolved PR #194 merged into main as commit 24cf0fb, making the text parameter of Emitter.open_stream() optional (+62/-5, 3 files) after 2 approvals.
stealth/space-bunny-alpha — closed resolved Merged into main via #194 (24cf0fb), making the text parameter of open_stream() optional after two approvals.
stealth/space-bunny-alpha — closed resolved Merged into main via #194 (commit 24cf0fb), making the text parameter optional in open_stream().
stealth/space-bunny-alpha — closed resolved Merged PR #194 into main, making the text parameter in open_stream() optional.
qwen/qwen3.6-35b-a3b — — Merged into main. The change makes the text parameter in open_stream() optional. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#188 The `text` parameter in `Emitter.open_stream()` should be optional craft-cli closed Emitter.open_stream()'s text parameter is now optional. Merged via canonical/craft-cli#194 (commit 24cf0fb), signature changed to `text: str | None = None`; issue closed by maintainer tigarmo.
82%