← Back to issue list

build: update ruff settings

View original Github issue

Metadata

Project
craft-cli
Number
#236
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in ddc3fd5, updating Ruff settings; follow-up PR #237 (675d42a) fixed the reported Pyright configuration failure.

Resolution: closed resolved

Reason: PR #236 merged as commit ddc3fd5. Its Pyright configuration failure was fixed by merged PR #237 in commit 675d42a.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? Pyright failure fixed by #237

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in ddc3fd5, updating Ruff settings; follow-up PR #237 (675d42a) fixed the reported Pyright configuration failure.
stealth/space-bunny-alpha — closed resolved Ruff settings update merged; the PR notes that the Pyright failure was fixed by #237.
qwen/qwen3.6-35b-a3b — — Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.

Update history

No update history recorded yet.

Related work

  • Related To: craft-cli#237 (confidence 100%)

    Merged follow-up that corrected the Pyright ignore configuration identified in PR #236.

Related issues

Issue Project State Summary Similarity
#510 build: update ruff settings craft-providers merged Merged PR #510 updated the Ruff configuration and was committed as bc34c1c.
86%
#660 build: update ruff settings craft-parts closed Ruff configuration PR was closed unmerged after prolonged inactivity; its six-line settings update was not applied.
84%
#201 build: update ruff settings craft-application closed Ruff-settings update was approved but PR #201 was closed unmerged after about 2.6 years without CI activity or follow-up.
79%
#481 build: update ruff settings rockcraft closed Ruff lint-config tweak PR closed unmerged; maintainer lengau closed it 2024-08-28 as superseded by #675 ("style(lint): replace pylint with ruff", merged as commit b7d70598).
77%
#1517 build: update ruff settings charmcraft merged Merged into charmcraft as commit 33854f04, updating the project's Ruff lint configuration (+6/-6).
77%
#85 build(deps): update dependency ruff to ~=0.11.2 craft-grammar merged Merged PR #85 as commit 93ac0ac, updating Ruff from ~=0.7.0 to ~=0.11.2.
75%
#41 build(deps): update to ruff 0.6.1 craft-grammar merged Renovate-style dependency bump PR updating the Ruff build dependency to 0.6.1 across three files (+4/-4). Approved by 2 reviewers with no unresolved comments and merged into main as commit 2f07089.
74%
#192 chore: update ruff settings starbase merged Merged Ruff configuration updates across two files (+6/-6) in commit d319ea9 after approval.
72%
#113 update ruff pre-commit craft-platforms merged Merged #113, updating Ruff's pre-commit configuration; the change landed in commit 1740611.
72%
#43 build(deps): update dependency ruff to ~=0.6.1 - autoclosed craft-grammar closed Autoclosed unmerged after #41 already applied the Ruff 0.6.1 update in commit 2f07089.
71%