← Back to issue list

build: update ruff settings

View original Github issue

Metadata

Project
craft-cli
Number
#236
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? Pyright failure fixed by #237

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.
qwen3.6-35b-a3b-mtp-q6 Merged update to ruff configuration settings. Resolved a Pyright failure addressed in #237. Passed tox checks and contribution guidelines.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1517 build: update ruff settings charmcraft merged Merged update to ruff configuration settings. The one-file build adjustment received approval from two reviewers and was integrated without comments or CI issues.
91%
#201 build: update ruff settings craft-application closed Merged after receiving approval and passing CI checks, the pull request updated ruff settings with a single-line build configuration change.
91%
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
86%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
86%
#319 style: update linting configuration for ruff 0.9 starbase merged Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR.
85%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged after approval by two reviewers and passing CI. The change updates the codebase to comply with ruff 0.5 linting rules, adjusting style configurations and fixing formatting across one file.
85%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged after two approvals and passing all CI checks. Resolves linting compatibility issues with newer ruff versions, updating five files.
85%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
84%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
84%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
84%