← Back to issue list

style: fix pyright config

View original Github issue

Metadata

Project
craft-cli
Number
#237
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? These ignores were supposed to be recursive. Ope

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
qwen3.6-35b-a3b-mtp-q6 Merged a pull request that corrected the pyright configuration by making ignore rules recursive. The change was integrated into the main branch without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
85%
#639 style: update pyright craft-parts merged Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files.
82%
#117 chore: fix pyright config craft-store merged Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.
82%
#4233 type: workaround for pyright bug snapcraft merged Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase.
81%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
80%
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
80%
#251 lint: add ignore for new pyright rockcraft merged Merged a one-file change adding a pyright ignore directive to suppress warnings about unknown xdg fields introduced in pyright 1.1.306. Approved by two reviewers and passed all CI checks.
80%
#186 style(typing): update pyright craft-application merged Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
79%
#16 style: make pyright less concerned about grammar methods craft-grammar merged Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.
78%
#158 chore: fix pyright error craft-archives merged Merged a maintainer's pull request that resolved a pyright error by removing a single line. Approved by three reviewers and passed CI checks before integration.
78%