← Back to issue list

style: fix pyright config

View original Github issue

Metadata

Project
craft-cli
Number
#237
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.

Resolution: closed resolved

Reason: PR #237 was approved and merged, resolving the Pyright configuration error in commit 675d42a by making both ignore patterns recursive.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? These ignores were supposed to be recursive. Ope

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-cli#237, a two-line fix making the Pyright configuration's two ignore patterns apply recursively; approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#639 style: update pyright craft-parts merged Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files.
79%
#186 style(typing): update pyright craft-application merged Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
78%
#158 style(types): update pyright craft-store merged Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.
76%
#251 lint: add ignore for new pyright rockcraft merged Merged PR #251 added a Pyright ignore for unknown xdg fields introduced by Pyright 1.1.306 (commit e4acb2ae).
76%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
75%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.
75%
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
73%
#65 Fixed new pyright issues. craft-cli merged Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479).
73%
#117 chore: fix pyright config craft-store merged Pyright configuration fixes from #117 were approved by two reviewers and merged into the project.
72%
#4485 style(lint): fix pyright errors snapcraft merged Merged PR #4485, fixing Pyright lint errors across nine files with three reviewer approvals.
72%