← Back to issue list

chore: switch to ruff snap

View original Github issue

Metadata

Project
craft-cli
Number
#250
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #250 as commit 35b6ab3, switching Ruff usage to its snap across three files (+5/-5); it received two approvals.

Resolution: closed resolved

Reason: PR #250 was merged into the mainline as commit 35b6ab3. It replaced Ruff installation/usage paths with the Ruff snap.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #250 as commit 35b6ab3, switching Ruff usage to its snap across three files (+5/-5); it received two approvals.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-cli#250, switching Ruff use to its snap across three files (+5/−5). The change received two approvals and was acknowledged by maintainer tigarmo.
qwen/qwen3.6-35b-a3b — — Merged following two approvals and successful CI checks. The change switches the project to the ruff snap, updating three files with five additions and five deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#204 chore: use ruff snap starbase merged Merged PR #204 in commit 09b91ba, switching Ruff usage in four files to the Ruff snap.
93%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
87%
#192 chore: update ruff settings starbase merged Merged Ruff configuration updates across two files (+6/-6) in commit d319ea9 after approval.
81%
#700 chore: update ruff craft-parts merged Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702.
81%
#566 chore(deps): update dependency lint/ruff to v0.4.3 craft-providers merged Renovate PR #566 bumped the lint/ruff pin from ==0.4.2 to ==0.4.3 (+1/-1 line). Approved by @mr-cal (who noted ruff would move to a snap at the next Starbase merge) and merged as commit e7b2ddc.
80%
#205 chore(deps): update dependency lint/ruff to v0.2.1 - autoclosed craft-application closed Renovate PR #205 was auto-closed unmerged; PR #206 replaced its Ruff package pin with Ruff from the Snap.
79%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
79%
#2442 chore: fix ruff warnings from test files charmcraft merged PR #2442 merged (commit 8d54de9c): replaced deprecated Ruff-flagged constructs in five test files, clearing lint deprecation warnings. Only snap-store-tests failed, unrelated to the change.
78%
#4417 chore(deps): update ruff to 0.1.1 and fix lint issues snapcraft merged Ruff 0.1.1 dependency bump plus lint fixes merged to snapcraft main as commit 4b1cff546 (PR #4417, +66/-36 across 19 files). A later follow-up, style: ruff 0.16 (#582), superseded the pin.
78%
#119 chore(deps): update dependency lint/ruff to v0.0.284 starbase merged Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes.
78%