chore: fix ruff warnings from test files
Metadata
Current evaluation
PR #2442 merged (commit 8d54de9c): replaced deprecated Ruff-flagged constructs in five test files, clearing lint deprecation warnings. Only snap-store-tests failed, unrelated to the change.
Resolution: closed resolved
Reason: The PR was approved and merged into charmcraft as commit 8d54de9c ("chore: fix ruff warnings from test files (#2442)"), a 25-line-insertion/30-line-deletion cleanup of deprecated lint constructs in test files; the lone failing check (snap-store-tests) is unrelated to lint-only test changes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Ruff was giving deprecation warnings about these every time you lint.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2442 merged (commit 8d54de9c): replaced deprecated Ruff-flagged constructs in five test files, clearing lint deprecation warnings. Only snap-store-tests failed, unrelated to the change. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2442 (commit 8d54de9c), replacing deprecated Ruff constructs in five test files to remove lint warnings. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve ruff deprecation warnings in test files. Automated type-checking notifications flagged pre-existing errors but explicitly stated they required no action. The changes were successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #1347 chore(deps): update ruff and fix new linting errors | charmcraft | merged | Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724. | |
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking. | |
| #566 chore(deps): update dependency lint/ruff to v0.4.3 | craft-providers | merged | Renovate PR #566 bumped the lint/ruff pin from ==0.4.2 to ==0.4.3 (+1/-1 line). Approved by @mr-cal (who noted ruff would move to a snap at the next Starbase merge) and merged as commit e7b2ddc. | |
| #250 chore: switch to ruff snap | craft-cli | merged | Merged PR #250 as commit 35b6ab3, switching Ruff usage to its snap across three files (+5/-5); it received two approvals. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409. | |
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #119 chore(deps): update dependency lint/ruff to v0.0.284 | starbase | merged | Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes. | |
| #205 chore(deps): update dependency lint/ruff to v0.2.1 - autoclosed | craft-application | closed | Renovate PR #205 was auto-closed unmerged; PR #206 replaced its Ruff package pin with Ruff from the Snap. | |
| #578 chore(deps): update dependency lint/ruff to v0.4.10 | craft-providers | merged | Renovate PR merged: bumped the lint/ruff dependency from 0.4.8 to 0.4.10 (commit 117db56) after reviewer approval; a single-line version change. |