chore: fix ruff warnings from test files
Metadata
Current evaluation
Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action.
Suggested action: —
No scores available.
Issue body
Ruff was giving deprecation warnings about these every time you lint.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve ruff deprecation warnings in test files. Automated type-checking notifications flagged pre-existing errors but explicitly stated they required no action. The changes were successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve Ruff deprecation warnings in test files. Automated type-checking failures were reported but flagged as non-blocking notifications. The linting fixes were accepted and integrated into the codebase. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge. | |
| #1347 chore(deps): update ruff and fix new linting errors | charmcraft | merged | Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated. | |
| #700 chore: update ruff | craft-parts | merged | Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change. | |
| #1683 chore: explicitly use the 'check' command to avoid ruff warning about it | charmcraft | merged | Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks. | |
| #5281 chore: clean up some warnings | snapcraft | merged | Merged a cleanup commit series resolving deprecation warnings across 21 files, cutting test output from over 3000 to 700. Risky changes and upstream warnings were excluded. Approved by two reviewers and passed CI. | |
| #192 chore: update ruff settings | starbase | merged | Merged updates to ruff configuration settings across two files. Approved by one reviewer, passed CI checks, and integrated into the main branch. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409. | |
| #200 chore(deps): update ruff and its configuration | craft-application | merged | Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions. | |
| #146 chore(deps): include ruff in dev updates | starbase | merged | Merged into main after approval and passing CI. The update incorporates the ruff linter into development dependencies following its 0.1 release, changing one file with no effect on test coverage. |