Be more resilient on double Emitter's init.
Metadata
Current evaluation
Merged in craft-cli#28 (commit da836f8): duplicate Emitter initialization now fails explicitly in regular mode, while TESTMODE closes and reinitializes it.
Resolution: closed resolved
Reason: PR #28 was merged after approval. Commit da836f8 adds explicit regular-mode error handling and safe stop-and-reinitialize behavior for duplicate Emitter initialization in TESTMODE.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
So, now:
- it fails explicitly in regular mode (as if you're using the lib, and double init Emitter, you have a problem using the lib)
- behaves nicely in TESTMODE (closing self and re-initiating), as it's normal in tests that a double init may happen because of tests
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in craft-cli#28 (commit da836f8): duplicate Emitter initialization now fails explicitly in regular mode, while TESTMODE closes and reinitializes it. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged hardening for double Emitter initialization: regular mode now fails explicitly, while test mode closes and reinitializes it. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged by facundobatista. Improves resilience for double Emitter initialization by failing explicitly in regular mode while gracefully handling it in test mode. Approved and passed CI checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #76 Added init_emitter and emitter fixtures (CRAFT-994). | craft-cli | merged | Merged PR #76 (commit 826a57f), adding tested init_emitter and emitter pytest fixtures, removing a redundant conftest fixture, and fixing #57. |