Added init_emitter and emitter fixtures (CRAFT-994).
Metadata
Current evaluation
Merged PR #76 (commit 826a57f), adding tested init_emitter and emitter pytest fixtures, removing a redundant conftest fixture, and fixing #57.
Resolution: closed resolved
Reason: The approved PR was merged as commit 826a57f. It added and tested the public emitter fixtures and explicitly fixes canonical/craft-cli#57.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Both are brought from Charmcraft, but here are also tested (as they are not really *used*, but are provided for users of the library).
As these fixtures also work for the project itself (because for development the project itself is installed), I removed the redundant fixture in `conftest.py`. Related to this, instead of enabling that fixture in a couple of test files, in consideration that the "real" `init_emitter` fixture has `autouse=True`, I just turned it off where we didn't want to mess with tests.
Fixes #57.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #76 (commit 826a57f), adding tested init_emitter and emitter pytest fixtures, removing a redundant conftest fixture, and fixing #57. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #76 added tested autouse init_emitter and emitter fixtures, removed a redundant fixture, and fixed #57 in merge commit 826a57f. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as canonical/craft-cli#76 (826a57f), adding tested init_emitter and emitter fixtures for CRAFT-994, removing a redundant conftest fixture, and fixing #57. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after review and CI approval. Introduced init_emitter and emitter fixtures from Charmcraft, removed redundant conftest.py fixture, and adjusted autouse configuration to resolve issue #57. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#57
(confidence 100%)
The issue requested an emit-testing fixture and was resolved by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #57 Provide a pytest fixture to simplify tests that use `emit` | craft-cli | closed | Added installable pytest fixtures for emitter testing via merged PR canonical/craft-cli#76 (merge commit 826a57f). | |
| #28 Be more resilient on double Emitter's init. | craft-cli | merged | Merged in craft-cli#28 (commit da836f8): duplicate Emitter initialization now fails explicitly in regular mode, while TESTMODE closes and reinitializes it. |