← Back to issue list

build(style): switch to the pyright snap

View original Github issue

Metadata

Project
craft-cli
Number
#337
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged: swapped the pyright pip package for the pyright snap in build/tox config (+1/-17, 2 files), commit 21d7e62. Setup handled by existing common.mk logic; all CI checks passed.

Resolution: closed resolved

Reason: PR #337 was approved and merged into main as commit 21d7e62, removing pyright from tox requirements and relying on the pre-existing common.mk snap-install fallback (confirmed in lengau's closing comment).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This switches from the pyright pip package to the pyright snap. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged: swapped the pyright pip package for the pyright snap in build/tox config (+1/-17, 2 files), commit 21d7e62. Setup handled by existing common.mk logic; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged after approval: replaced the pyright pip package with the pyright snap; existing common.mk setup handles installation, and all CI checks passed.
qwen/qwen3.6-35b-a3b — — Merged. Replaced the pyright pip package with the pyright snap in the build configuration. Approved by two reviewers and passed all CI checks. Snap installation is handled via the existing common.mk setup.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#479 (confidence 80%)

    Later PR dropping pyright (and mypy) entirely in favour of ty, commit 0e49c01 — renders the snap switch moot

  • Related To: canonical/craft-cli#327 (confidence 55%)

    Preceding commit4c45c0e 'build(deps): remove pyright' trimmed pyright deps ahead of this snap-based change

Related issues

No related issues found above the similarity threshold.