← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-cli
Number
#479
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.

Resolution: closed resolved

Reason: The PR was approved by two reviewers and merged as commit 0e49c01, replacing mypy and pyright with the ty type checker. Follow-up commit 6d3dca9 (PR #485, 'style: ty 0.0.79') bumps ty, confirming the change landed and ty is now the sole type checker.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Drops mypy and pyright in favor of ty.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR replacing mypy and pyright with ty; 8 files changed (+17/-341), and all lint, fast, slow, and minimum-dependency CI checks passed.
qwen/qwen3.8-27b — — Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 20
Confidence: 95
needs review Replaces mypy and pyright type checkers with ty. All CI checks pass, and the PR has one maintainer approval with zero unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Removes mypy and pyright type checkers, replacing them with ty. All CI checks pass. Awaiting maintainer review.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 15
Confidence: 90
needs review Swaps mypy and pyright for ty in the toolchain. Submitted by a maintainer, currently awaiting review with CI checks pending.

Update history

Date Change
updated
updated
updated
created

Related work

  • Related To: canonical/craft-cli#485 (confidence 80%)

    Commit 6d3dca9 'style: ty 0.0.79' bumps the newly adopted ty checker after this PR merged.

  • Likely Fixed By: canonical/craft-cli#407 (confidence 70%)

    Commit d38e0f4 'style(types): enable type checking with ty' introduced ty, which #479 makes the only type checker by removing mypy/pyright.

  • Related To: canonical/craft-cli#434 (confidence 55%)

    Commit ef91a65 'style: silence ty warnings' is part of the same migration effort toward ty.

Related issues

Issue Project State Summary Similarity
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
89%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
87%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
86%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
84%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
80%
#6007 Remove mypy and pyright snapcraft closed Request to drop mypy and pyright for ty was resolved by merged PR #6247 ("style: go all-in on ty", commit 534d7dce7), which replaced both checkers with ty and removed the unused-ignore-comment suppression.
79%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
79%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
79%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
78%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
75%