← Back to issue list

docs: add `CONTRIBUTING.md`

View original Github issue

Metadata

Project
craft-cli
Number
#352
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

PR #352 by medubelko merged as commit 6059480, adding CONTRIBUTING.md (shared copy from other Starcraft projects); all CI checks passed despite 17 unresolved review comments.

Resolution: closed resolved

Reason: The pull request itself was merged into main by a maintainer in commit 6059480 ("docs: add CONTRIBUTING.md (#352)"), with all listed CI checks (lint, fast/slow tests, security scans, CLA) passing. Follow-up polish landed in #368 and #370, and #427 later removed bounty instructions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Bring in shared copy from other Starcraft projects. --- - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? The tests are failing for me.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #352 by medubelko merged as commit 6059480, adding CONTRIBUTING.md (shared copy from other Starcraft projects); all CI checks passed despite 17 unresolved review comments.
stealth/space-bunny-alpha — closed resolved Merged shared contribution guidelines for craft-cli in PR #352 (commit 6059480), updating 3 files with all CI checks passing.
qwen/qwen3.6-35b-a3b — — Merged a shared CONTRIBUTING.md file from other Starcraft projects. Approved by two reviewers and passing all CI checks, the pull request added 279 lines and removed 321 across three files to establish project guidelines.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#368 (confidence 92%)

    Follow-up 'docs: update CONTRIBUTING.md' refining the file introduced here.

  • Related To: canonical/craft-cli#370 (confidence 92%)

    Follow-up 'docs: align CONTRIBUTING.md with template' completing the alignment this PR started.

  • Related To: canonical/craft-cli#427 (confidence 80%)

    Later commit88bcade removes bounty instructions from the same CONTRIBUTING.md.

  • Duplicate Of: canonical/craft-parts#1134 (confidence 70%)

    Sibling Starcraft project applying the same shared contribution-guidelines copy to its CONTRIBUTING.md.

Related issues

Issue Project State Summary Similarity
#2353 docs: update `CONTRIBUTING.md` charmcraft merged Docs-only PR #2353 merged as commit 62abb2f4, replacing CONTRIBUTING.md with shared Starcraft guidance (+257/-58 across 2 files) and dropping a misplaced README link; approved by 2 reviewers.
86%
#448 docs: add `CONTRIBUTING.md` template starbase merged PR #448 merged, adding a CONTRIBUTING.md template to Starbase and deleting HACKING.md, streamlining the contribution/merge process. Landed as commit ebfec44.
78%
#370 docs: update `CONTRIBUTING.md` craft-cli merged Merged PR #370 (commit b7a0dbb), aligning CONTRIBUTING.md with the project template and incorporating review wording changes.
77%
#368 docs: update CONTRIBUTING.md craft-cli merged Merged PR #368 (commit e75f8ef) updated CONTRIBUTING.md to align with the project template, +107/-55 lines in one file; all CI checks passed.
75%
#1142 docs: maintain contributing.md craft-parts merged Merged docs PR by maintainer medubelko fixing an error and improving a step in CONTRIBUTING.md (+3/-4 lines). Approved by 2 reviewers, all CI green; landed as commit 14b47207 ('docs: maintain contributing.md (#1142)').
74%
#841 docs: update `CONTRIBUTING.md` craft-application merged Merged PR #841, applying five CONTRIBUTING.md line replacements from reviews in other Canonical repositories; all CI checks passed.
74%
#150 docs: add contributing file rockcraft merged Merged PR #150 in commit 9ce3440e, adding a 17-line CONTRIBUTING.rst with code contribution guidelines.
74%
#215 docs: add CONTRIBUTING.md imagecraft merged Merged PR #215 in commit b0aa9f2, replacing HACKING.md with a 312-line CONTRIBUTING.md aligned to the project's contribution model.
73%
#2404 docs: update `CONTRIBUTING.md` charmcraft merged Merged docs PR #2404 as commit 1c0f9884, applying a small +5/-5 edit to CONTRIBUTING.md carrying over review feedback from other Canonical repos; 3 approvals, all CI green.
72%
#437 docs: add vale off/on comments for Starcraft in README craft-store merged Merged PR #437 adding Vale off/on comments to the README to suppress Starcraft linting warnings when the file is brought into child repositories.
72%