← Back to issue list

docs: update `CONTRIBUTING.md`

View original Github issue

Metadata

Project
charmcraft
Number
#2353
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

Docs-only PR #2353 merged as commit 62abb2f4, replacing CONTRIBUTING.md with shared Starcraft guidance (+257/-58 across 2 files) and dropping a misplaced README link; approved by 2 reviewers.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 62abb2f4 ("docs: update `CONTRIBUTING.md` (#2353)"), which appears in the CONTRIBUTING.md history of the repo. The updated file now contains the shared Starcraft review-expectations text, and follow-up docs PRs #2382 and #2404 built on the same file.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Bring in shared copy from other Starcraft projects. - Remove misplaced link in README.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Docs-only PR #2353 merged as commit 62abb2f4, replacing CONTRIBUTING.md with shared Starcraft guidance (+257/-58 across 2 files) and dropping a misplaced README link; approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Documentation update merged: CONTRIBUTING.md now includes shared Starcraft guidance, and a misplaced README link was removed. The change was approved by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged shared Starcraft contribution guidance into CONTRIBUTING.md and removed a misplaced README link, updating two files with approved reviews.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers. Updated CONTRIBUTING.md with shared documentation from other Starcraft projects and corrected a misplaced README link. Modified two files, adding 257 lines and removing 58.
qwen3.6-35b-a3b-mtp-q6 — — Successfully merged documentation update that integrated shared copy from other Starcraft projects into CONTRIBUTING.md and removed a misplaced README link.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2382 (confidence 80%)

    Later merged docs-only PR (commit 08bdaed6, +103/-60) further rewrote CONTRIBUTING.md, with fixes from #2392 and #2404.

  • Related To: canonical/charmcraft#2404 (confidence 75%)

    Small follow-up edit (+5/-5) to the same CONTRIBUTING.md from the same maintainer stream.

  • Related To: canonical/charmcraft#2392 (confidence 55%)

    Follow-up fix (724cf55b) installing system packages in `make setup`, aligning with the Starbase setup instructions introduced by #2353.

Related issues

Issue Project State Summary Similarity
#352 docs: add `CONTRIBUTING.md` craft-cli merged PR #352 by medubelko merged as commit 6059480, adding CONTRIBUTING.md (shared copy from other Starcraft projects); all CI checks passed despite 17 unresolved review comments.
86%
#1052 docs: Update README.md contributing link rockcraft merged Merged PR #1052 (commit 509abf1a) fixed the broken contributing link in README.md, pointing it to CONTRIBUTING.md instead of the stale URL. Docs-only, +1/-1 lines; approved by 3 reviewers.
80%
#5637 docs: fix CONTRIBUTING.md typos snapcraft merged Docs-only PR merged as commit 4ad38c556, correcting typos and internal links in CONTRIBUTING.md (+3/-3, one file); approved by two reviewers.
79%
#370 docs: update `CONTRIBUTING.md` craft-cli merged Merged PR #370 (commit b7a0dbb), aligning CONTRIBUTING.md with the project template and incorporating review wording changes.
78%
#791 docs: update CONTRIBUTING.md craft-application merged Docs-only PR #791 merged as commit 60bc3fae, rewriting CONTRIBUTING.md (+278/-319, 3 files) and deleting HACKING.md. Approved by 2 reviewers; only the OSV-scanner check failed.
78%
#416 docs: update contribution links starbase merged Docs-only PR merged as commit 96a080d, updating Starbase's contribution links in docs/index.rst to match Snapcraft's docs; approved by 2 reviewers with all CI checks green.
77%
#448 docs: add `CONTRIBUTING.md` template starbase merged PR #448 merged, adding a CONTRIBUTING.md template to Starbase and deleting HACKING.md, streamlining the contribution/merge process. Landed as commit ebfec44.
76%
#336 docs: fix some formatting errors in README starbase merged Docs-only PR merged as commit d3d4189, adding 10 lines to starbase's README to fix spacing/formatting errors that slipped past the earlier README cleanup in #331 (commit de0d308). Approved by 2 reviewers, no CI.
75%
#368 docs: update CONTRIBUTING.md craft-cli merged Merged PR #368 (commit e75f8ef) updated CONTRIBUTING.md to align with the project template, +107/-55 lines in one file; all CI checks passed.
75%
#2404 docs: update `CONTRIBUTING.md` charmcraft merged Merged docs PR #2404 as commit 1c0f9884, applying a small +5/-5 edit to CONTRIBUTING.md carrying over review feedback from other Canonical repos; 3 approvals, all CI green.
75%