Declare public API names
Metadata
Current evaluation
Merged to declare public API names and satisfy mypy strict mode. Emitter visibility was debated but accepted. Approved and merged by maintainer, acknowledging it as the main message system interface.
Suggested action: —
No scores available.
Issue body
`mypy --strict` enforces these by default.
I'm not sure whether `Emitter` should be public. It doesn't have an underscore, but it also isn't used by charmcraft - I guess it might be needed to implement test fixtures? I decided to err on the side of strictness and you can always open it up if you want.
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? (Canonical employee, so not required.)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to declare public API names and satisfy mypy strict mode. Emitter visibility was debated but accepted. Approved and merged by maintainer, acknowledging it as the main message system interface. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to satisfy mypy strict public API naming rules. Maintainer approved the changes despite minor concerns about Emitter visibility, noting it is the main message interface but agreed to land the PR as submitted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #52 api: declare public api names | craft-cli | merged | Merged after reviewer approval and passing CI. Explicitly exports public API names to satisfy PEP-561 py.typed markers and pyright enforcement. Updated one file with twelve additions. |