← Back to issue list

api: declare public api names

View original Github issue

Metadata

Project
craft-cli
Number
#52
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR (commit 7dfe254, merged via 6d5d9be) added an explicit __all__ to craft_cli/__init__.py listing the 11 public API names, satisfying pyright's PEP-561 py.typed enforcement.

Resolution: closed resolved

Reason: The PR itself was merged into main by maintainer cmatsuoka with approval and no unresolved review comments; commit 7dfe254 'api: declare public api names' adds the __all__ declaration to craft_cli/__init__.py, which is still present in the current tree.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Explicitly export public API names. This is enforced by pyright in packages with the PEP-561 `py.typed` marker. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR (commit 7dfe254, merged via 6d5d9be) added an explicit __all__ to craft_cli/__init__.py listing the 11 public API names, satisfying pyright's PEP-561 py.typed enforcement.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-cli#52 (6d5d9be), adding 12 explicit public API exports to satisfy pyright enforcement for PEP-561 py.typed packages.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI. Explicitly exports public API names to satisfy PEP-561 py.typed markers and pyright enforcement. Updated one file with twelve additions.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-providers#78 (confidence 70%)

    Same CRAFT-570 change ('api: declare public api names') applied to the sibling craft-providers package, merged as PR #78.

Related issues

Issue Project State Summary Similarity
#78 api: declare public api names (CRAFT-570) craft-providers merged Merged PR #78 (commit 06c2176) explicitly exported craft-providers public API names for PEP 561 py.typed compatibility.
85%
#142 api: add missing typed marker and declare public api names (CRAFT-575) craft-parts merged Merged PR #142 via 47ce20b7, adding the missing PEP 561 py.typed marker and explicit public API exports for Pyright.
72%
#38 Declare public API names craft-cli merged Merged PR #38 (a89b2be), adding explicit public API declarations for mypy --strict; Emitter remained non-public pending clarification.
70%