← Back to issue list

api: declare public api names

View original Github issue

Metadata

Project
craft-cli
Number
#52
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after reviewer approval and passing CI. Explicitly exports public API names to satisfy PEP-561 py.typed markers and pyright enforcement. Updated one file with twelve additions.

Suggested action:

No scores available.

Issue body

Explicitly export public API names. This is enforced by pyright in packages with the PEP-561 `py.typed` marker. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval and passing CI. Explicitly exports public API names to satisfy PEP-561 py.typed markers and pyright enforcement. Updated one file with twelve additions.
qwen3.6-35b-a3b-mtp-q6 Merged explicit public API name exports to enforce PEP-561 py.typed compliance and pyright type checking. The change aligns package exports with static analysis requirements.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#142 api: add missing typed marker and declare public api names (CRAFT-575) craft-parts merged Merged changes adding the missing PEP-561 py.typed marker and explicitly exporting public API names to satisfy pyright type checking. Approved by reviewer, passed CI, and updated 3 files.
85%
#38 Declare public API names craft-cli merged Merged to declare public API names and satisfy mypy strict mode. Emitter visibility was debated but accepted. Approved and merged by maintainer, acknowledging it as the main message system interface.
72%