← Back to issue list

feat(pytest-plugin): negative assertion methods

View original Github issue

Metadata

Project
craft-cli
Number
#492
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #492 adding negative assertion methods to the craft-cli pytest plugin, resolving feature request #489.

Resolution: closed resolved

Reason: The feature was implemented and merged in PR #492. The PR adds negative assertion methods to the pytest plugin as requested in issue #489.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- `assert_messages` and `assert_interactions` are out of scope as they are different search mechanisms that don't really need negation available. Closes #489

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #492 adding negative assertion methods to the craft-cli pytest plugin, resolving feature request #489.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 30
Complexity: 30
Confidence: 80
Actionability: 85
needs review Adds negative assertion methods (assert_not_message, assert_not_warning, etc.) to RecordingEmitter pytest plugin; assert_messages/assert_interactions excluded. Approved, CI mostly green with macOS fast tests pending.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 26
Complexity: 25
Confidence: 75
Actionability: 70
needs review Adds negative assertion methods (assert_not_*) to RecordingEmitter pytest plugin with tests; closes #489. CI mostly green except macOS fast tests.
~deepseek/deepseek-pro-latest
Impact: 45
Quick Win: 13
Complexity: 35
Confidence: 55
Actionability: 45
keep open Adds assert_not_* negative assertion methods to RecordingEmitter pytest plugin plus tests, closing #489. One macOS fast-test CI check is failing and 2 review comments remain unresolved.
~deepseek/deepseek-pro-latest
Impact: 45
Quick Win: 17
Complexity: 30
Confidence: 75
Actionability: 55
needs review Adds negative assertion methods (assert_not_message, assert_not_warning, etc.) to the RecordingEmitter pytest plugin, closing #489. All test CI passes; lint/files check is failing.

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
created

Related work

  • Likely Fixed By: canonical/craft-cli#489 (confidence 100%)

    Issue #489 requested negative assertion methods, which were implemented and closed by this PR.

Related issues

Issue Project State Summary Similarity
#489 Add negative assertions in pytest plugin craft-cli closed Feature request to add negative assertions to the pytest plugin was closed without implementation. No PRs found adding `assert_not_*` methods.
76%
#311 fix(pytest): revert "add an assert_error plugin method" craft-cli merged Merged #311 (84df9bf) reverted #218, removing the breaking pytest assert_error plugin added in 2.11.0. Craft-cli 2.12.0 recommends capsys instead; support was deferred to 3.0.
70%