fix(pytest): revert "add an assert_error plugin method"
Metadata
Current evaluation
Merged #311 (84df9bf) reverted #218, removing the breaking pytest assert_error plugin added in 2.11.0. Craft-cli 2.12.0 recommends capsys instead; support was deferred to 3.0.
Resolution: closed resolved
Reason: PR #311 was merged as commit 84df9bf and reverted #218 (dd3fe83) after its assert_error addition caused compatibility breakage. The 2.12.0 changelog records the removal and recommends capsys.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Reverts canonical/craft-cli#218
Breaks #162
Confirmed this is the cause. Compare:
- With #218: https://github.com/canonical/craft-application/actions/runs/12305359436/job/34344765176?pr=586
- Without: https://github.com/canonical/craft-application/actions/runs/12305776816/job/34346114053?pr=594
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #311 (84df9bf) reverted #218, removing the breaking pytest assert_error plugin added in 2.11.0. Craft-cli 2.12.0 recommends capsys instead; support was deferred to 3.0. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #311 (84df9bf), reverting #218 to restore compatibility broken in 2.11.0; assert_error support is deferred to 3.0. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a revert of the assert_error plugin method, fixing downstream CI failures. Approved by three reviewers and passing checks, the change restores test stability. Release versioning discussed as 2.11.1 or 3.0. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/craft-cli#218
(confidence 100%)
Its assert_error plugin addition was explicitly reverted as the source of the breakage.
-
Related To:
canonical/craft-cli#162
(confidence 95%)
The PR links #162 as broken by assert_error behavior; reintroduction was deferred to a major release.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #218 feat(pytest): add an assert_error plugin method | craft-cli | merged | Merged as dd3fe83 to add pytest assert_error for #162, but #311 reverted it in 84df9bf due to an unintended breaking change; release 2.12.0 documents its removal. | |
| #162 pytest plugin `assert_error` | craft-cli | closed | Feature request for a pytest plugin `assert_error` was implemented in #218 (dd3fe83, 2.11.0) then reverted by merged PR #311 (84df9bf) as a breaking change; 2.12.0 changelog documents its removal, deferring it to 3.0. | |
| #492 feat(pytest-plugin): negative assertion methods | craft-cli | merged | Merged PR #492 adding negative assertion methods to the craft-cli pytest plugin, resolving feature request #489. |