← Back to issue list

Don't add timestamps when the subprocess already does that

View original Github issue

Metadata

Project
craft-cli
Number
#61
Type
issue
State
open
Author
facundobatista
Labels
—
Created
Updated
Closed
—

Current evaluation

Request to add a sub_with_timestamps flag to emit.open_stream so Craft CLI skips its timestamp when the subprocess adds one. Author rethought it in 2022, noting emit.pause already hides duplicate timestamps; log timestamps remain but deemed fine.

Suggested action: close stale

Reason: The author (a maintainer) rethought this in 2022 and stated that emit.pause (added in PR #69) already prevents users from seeing multiple timestamps, with only log timestamps remaining, which they called 'probably fine.' The user-visible problem is thus resolved by a different mechanism, and the issue has been inactive for ~18 months with no labels or assignee.

Impact: 20 Quick Win: 14.0 Staleness: 75 Complexity: 30 Confidence: 80 Support Request: 5

Issue body

We need to add a flag to `emit.open_stream`, something like `sub_with_timestamps` (defaults to `False`), which would mean that the executed stuff will add its own timestamp, so in that case Craft CLI won't add the timestamp to the message This way, if we use emit.open_stream on something that has it's own Craft CLI stuff (or adds timestamps in some way), the outer timestamp will not be present; but if we run whatever (e.g. pip) it will add the timestamps as currently does.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 20
Quick Win: 14.0
Staleness: 75
Complexity: 30
Confidence: 80
Support Request: 5
close stale Request to add a sub_with_timestamps flag to emit.open_stream so Craft CLI skips its timestamp when the subprocess adds one. Author rethought it in 2022, noting emit.pause already hides duplicate timestamps; log timestamps remain but deemed fine.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 10
Confidence: 90
Support Request: 5
close stale Feature request to add a flag to emit.open_stream to skip timestamps when subprocesses provide them. The proposing maintainer later noted an alternative approach resolves the concern. Issue is inactive and the proposed feature is no longer relevant.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 20
Confidence: 85
Support Request: 10
close stale Proposes adding a sub_with_timestamps flag to emit.open_stream to prevent duplicate timestamps when subprocesses already output them. Author recently noted that emit.pause mitigates the issue, suggesting the feature may no longer be necessary.
qwen3.6-35b-a3b-mtp-q6
Staleness: 88
Complexity: 15
Confidence: 85
Support Request: 0
close stale Suggests a flag to skip Craft CLI timestamps when subprocesses already add them, avoiding duplicates. Maintainer reconsidered; emit.pause now prevents real-time duplication, making log duplicates acceptable. Issue deferred.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#69 (confidence 75%)

    PR #69 added the Emitter.pause() method, which the author cites as resolving the user-visible duplicate-timestamp problem.

Related issues

No related issues found above the similarity threshold.