← Back to issue list

Add a 'pause' method to the Emitter (CRAFT-907).

View original Github issue

Metadata

Project
craft-cli
Number
#69
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged adding a 'pause' method to the Emitter, which completely frees the terminal and stops all interactions and log retrieval. Includes test examples, approved by one reviewer, and modifies four files.

Suggested action: —

No scores available.

Issue body

While paused, the Emitter frees completely the terminal and does not do anything with it. Not even getting logs from it. Examples 21 and 22 added to easily test this new feature.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged adding a 'pause' method to the Emitter, which completely frees the terminal and stops all interactions and log retrieval. Includes test examples, approved by one reviewer, and modifies four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged adds a 'pause' method to the Emitter that completely frees the terminal, halting all interactions and log retrieval. Examples 21 and 22 were included for testing.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#740 Pause the Emitter when asking the user for input (CRAFT-952). charmcraft merged Merged. The pull request pauses the Emitter during user input prompts (CRAFT-952). Approved by one reviewer with zero unresolved comments. Changes span three files (+32/-7 lines), and the author confirmed successful Windows testing.
76%
#92 Added the .debug and .verbose methods to Emitter (CRAFT-1137). craft-cli merged Added .debug and .verbose methods to the Emitter class per the new specification. Refactored pause start and end signals to use internal .debug. Approved, passed CI, and merged with 221 additions and 8 deletions across four files.
75%
#753 Pause the emitter while launching the user-requested shell (CRAFT-871). charmcraft merged Merged after approval. Pauses the emitter during user-requested shell launches to resolve CRAFT-871. Also corrected flake8 issue reporting.
70%