← Back to issue list

Add a 'pause' method to the Emitter (CRAFT-907).

View original Github issue

Metadata

Project
craft-cli
Number
#69
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #69 (commit b8cbbc6; merge commit d8171ce) added Emitter.pause(), releasing the terminal and suspending log retrieval while paused, with examples 21 and 22.

Resolution: closed resolved

Reason: PR #69 was merged via merge commit d8171ce, implementing Emitter.pause() in commit b8cbbc6 and adding examples 21 and 22 to cover the behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

While paused, the Emitter frees completely the terminal and does not do anything with it. Not even getting logs from it. Examples 21 and 22 added to easily test this new feature.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #69 (commit b8cbbc6; merge commit d8171ce) added Emitter.pause(), releasing the terminal and suspending log retrieval while paused, with examples 21 and 22.
stealth/space-bunny-alpha — closed resolved Merged PR #69, adding pause and resume support so Emitter releases the terminal and stops log retrieval while paused. Added examples 21 and 22 to cover the behavior.
qwen/qwen3.6-35b-a3b — — Merged adding a 'pause' method to the Emitter, which completely frees the terminal and stops all interactions and log retrieval. Includes test examples, approved by one reviewer, and modifies four files.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#67 Allow emitter to be paused craft-cli closed Emitter pausing was implemented and merged in canonical/craft-cli#69 via b8cbbc6 (merge d8171ce), with pause-related fixes in #71.
79%
#71 Improvements/fixes for the pause situation. craft-cli merged Merged in canonical/craft-cli#71 via 94338bd (implementation 187d900): logs append instead of truncating, and emitter activity is suppressed while paused or stopped.
72%
#740 Pause the Emitter when asking the user for input (CRAFT-952). charmcraft merged Merged #740 (e70ed86f; implementation 9acf2caa), pausing Charmcraft's Emitter during user-input prompts; the author confirmed it was tested on Windows.
72%