Improvements/fixes for the pause situation.
Metadata
Current evaluation
Merged in canonical/craft-cli#71 via 94338bd (implementation 187d900): logs append instead of truncating, and emitter activity is suppressed while paused or stopped.
Resolution: closed resolved
Reason: PR #71 merged through commit 94338bd, with implementation commit 187d900. It fixed pause/stop handling by appending to log files and ignoring emitter activity outside active states while safely tolerating repeated terminal calls.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- the _Printer now opens the log in "append" mode; this is particularly so after resuming the previous log is not truncated, but also is an improvement in general, as we allow users of the library to have better control if they provide the log filepath (if they want a fresh start, they can truncate it, before we were not leaving a choice)
- ensure the _Emitter is not used when paused... but I fixed this in a more generic way, ensuring that the _Emitter is not used when stopped! Except for the `ended_ok` and `error` methods, where we provide the possibility of double-endings (ignoring the call), to support race conditions when closing the lib.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-cli#71 via 94338bd (implementation 187d900): logs append instead of truncating, and emitter activity is suppressed while paused or stopped. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-cli#71: log output now appends, and emitters are prevented from running while paused or stopped, with idempotent shutdown handling. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR improving pause/resume handling. _Printer opens logs in append mode. _Emitter is blocked when stopped or paused, with race condition handling for double-endings. Approved, passed CI, +57/-24 lines across 4 files. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #67 Allow emitter to be paused | craft-cli | closed | Emitter pausing was implemented and merged in canonical/craft-cli#69 via b8cbbc6 (merge d8171ce), with pause-related fixes in #71. | |
| #69 Add a 'pause' method to the Emitter (CRAFT-907). | craft-cli | merged | Merged PR #69 (commit b8cbbc6; merge commit d8171ce) added Emitter.pause(), releasing the terminal and suspending log retrieval while paused, with examples 21 and 22. |