Improved the _Progresser and how it's used (CRAFT-1139).
Metadata
Current evaluation
Merged into main as commit 90b3c8e via PR #96, improving _Progresser with timestamps, start/end markers, and optional timestamped Printer progress bars for CRAFT-1139.
Resolution: closed resolved
Reason: PR #96 was approved and merged into main as commit 90b3c8e, with implementation commit e696c14. It added timestamped progress messages, explicit progress start/end markers, and optional timestamp display for Printer progress bars.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Details:
- it shows messages with timestamps when needed
- it marks the beginning and end of the progress in general (very useful for example for logs, where the *progress itself* is not recorded)
- as that context info is responsibility of the class itself, there is no more a separate message before putting it to work.
Also added support in the Printer to show the timestamp for the progress bar, if indicated.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as commit 90b3c8e via PR #96, improving _Progresser with timestamps, start/end markers, and optional timestamped Printer progress bars for CRAFT-1139. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Progresser improvements adding timestamps and progress start/end markers, plus optional timestamped progress bars in Printer (CRAFT-1139). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged _Progresser improvements enabling timestamp display, explicit start/end markers, and removal of redundant context messages. Added timestamp support to the Printer. Approved, passed CI, and modified 5 files (+132/-47 lines). |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #7 Added the 'progress' method to send progress messages (CRAFT-98). | craft-cli | merged | Merged PR #7 added Emitter.progress() for progress messages (CRAFT-98) in commit 079c538; merge commit: 77a34cc. | |
| #381 Replace "print"s for proper progress calls when we have the "messages to the user" lib integrated | charmcraft | closed | Prints in the store registry/client upload paths were replaced with craft-cli progress reporting; PR #586 (branch show-progress-properly, merge e50353c8, squash ab0603b6) added progress bars to Charmcraft's three upload points. |