← Back to issue list

feat(GrammarProcessor): make `checker` optional

View original Github issue

Metadata

Project
craft-grammar
Number
#133
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #133 merged (commit 9b70aa6), making GrammarProcessor's `checker` optional with a default no-op (lambda _: True); closes #131 and shipped in release 2.3.0.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers with all CI checks passing and merged as commit 9b70aa6 ('feat(GrammarProcessor): make `checker` optional (#133)'). craft_grammar/_processor.py now defaults `checker: Callable[[Any], bool] = lambda _: True`, and the changelog lists the change under release 2.3.0, closing issue #131.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #131 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #133 merged (commit 9b70aa6), making GrammarProcessor's `checker` optional with a default no-op (lambda _: True); closes #131 and shipped in release 2.3.0.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-grammar#133 (9b70aa6), making GrammarProcessor's checker optional with a default no-op lambda. Fixes #131.
qwen/qwen3.6-35b-a3b — — Merged to make the checker parameter optional in GrammarProcessor, resolving issue #131. Approved by two reviewers, passed all CI checks, and implemented with a 14-line change across two files.

Update history

No update history recorded yet.

Related work

  • Related To: craft-grammar#131 (confidence 98%)

    Issue #131 'Checker for grammar processor should be optional' is the issue this PR fixes.

Related issues

Issue Project State Summary Similarity
#131 Checker for grammar processor should be optional craft-grammar closed Resolved: PR canonical/craft-grammar#133 (commit 9b70aa6) merged, making GrammarProcessor's checker optional with a default no-op lambda, closing #131.
82%