← Back to issue list

feat(GrammarProcessor): make `checker` optional

View original Github issue

Metadata

Project
craft-grammar
Number
#133
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to make the checker parameter optional in GrammarProcessor, resolving issue #131. Approved by two reviewers, passed all CI checks, and implemented with a 14-line change across two files.

Suggested action:

No scores available.

Issue body

Fixes #131 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to make the checker parameter optional in GrammarProcessor, resolving issue #131. Approved by two reviewers, passed all CI checks, and implemented with a 14-line change across two files.
qwen3.6-35b-a3b-mtp-q6 Merged pull request making the checker parameter optional in GrammarProcessor. Resolves issue #131.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#131 Checker for grammar processor should be optional craft-grammar closed Resolved by making the checker parameter optional, defaulting to a lambda function to eliminate boilerplate. The proposed approach was approved and implemented.
80%