Checker for grammar processor should be optional
Metadata
Current evaluation
Resolved by making the checker parameter optional, defaulting to a lambda function to eliminate boilerplate. The proposed approach was approved and implemented.
Suggested action: —
No scores available.
Issue body
The [`checker` parameter](https://github.com/canonical/craft-grammar/blob/0408961a5dc7c7dd4961190b43b109d03ac9b508/craft_grammar/_processor.py#L61) for a GrammarProcessor should be optional.
This is because it isn't always required, but it takes a non-trivial amount of code to make it a no-op ([example](https://github.com/canonical/craft-application/blob/4d6c68cb7421e06375f0d35c59a3b654e36264c6/craft_application/grammar.py#L127-L138)).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Resolved by making the checker parameter optional, defaulting to a lambda function to eliminate boilerplate. The proposed approach was approved and implemented. | |
| qwen/qwen3.6-35b-a3b | — | — | The checker parameter for GrammarProcessor was made optional by setting a lambda as the default value. The maintainer approved the fix, which was merged to close the enhancement request. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by implementing a no-op lambda as the default checker value. A proposed pull request was approved by the maintainer, and the team agreed to use the lambda as the default, closing the enhancement request. | |
| qwen/qwen3.6-35b-a3b | — | — | The checker parameter in GrammarProcessor was made optional by using a lambda as the default value. The enhancement was resolved and merged via a related pull request after maintainer approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The request to make the checker parameter optional was addressed by adopting a lambda function as the default value. This approach was proposed in craft-application#899, approved by the maintainer, and resolved the issue. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #133 feat(GrammarProcessor): make `checker` optional | craft-grammar | merged | Merged to make the checker parameter optional in GrammarProcessor, resolving issue #131. Approved by two reviewers, passed all CI checks, and implemented with a 14-line change across two files. |