← Back to issue list

style: make pyright less concerned about grammar methods

View original Github issue

Metadata

Project
craft-grammar
Number
#16
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.
qwen3.6-35b-a3b-mtp-q6 Merged a configuration update to suppress pyright warnings for grammar methods. The change was integrated into the main branch without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#639 style: update pyright craft-parts merged Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files.
83%
#186 style(typing): update pyright craft-application merged Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
79%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
78%
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
77%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
77%
#2052 style(type): make pyright stricter charmcraft merged Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files.
76%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
74%
#421 style: drop mypy, pyright craft-store merged Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
74%
#1525 build: enable pyright charmcraft merged Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
74%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
73%