style(type): make pyright stricter
Metadata
Current evaluation
Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files.
Resolution: closed resolved
Reason: PR #2052 was approved and merged, completing the stricter Pyright configuration and corresponding type fixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This bumps two pyright warnings to errors and fixes those errors
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2052 was approved and merged, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/charmcraft#2052, promoting two pyright warnings to errors and fixing the resulting type errors across 16 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer PR that enforces stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1574 style(type): enable stricter pyright rules | charmcraft | merged | Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files. | |
| #186 style(typing): update pyright | craft-application | merged | Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20). | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files. | |
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. | |
| #1614 style(typing): enable most disabled pyright checks | charmcraft | merged | Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #2229 style: fix linting errors | charmcraft | merged | Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files. | |
| #16 style: make pyright less concerned about grammar methods | craft-grammar | merged | Merged in canonical/craft-grammar#16 via commit 3d2ef93, relaxing Pyright's handling of grammar methods through a small configuration update. | |
| #158 style(types): update pyright | craft-store | merged | Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers. | |
| #1528 Enable pyright and clear the typing issues | charmcraft | closed | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. |