← Back to issue list

build: add craft_grammar_docs sub-package

View original Github issue

Metadata

Project
craft-grammar
Number
#184
Type
pull request
State
merged
Author
medubelko
Labels
Created
Updated
Closed

Current evaluation

Merged the addition of the craft_grammar_docs sub-package to the build system. Approved by two reviewers and cleared CI checks. The change updates four files with minimal build configuration adjustments.

Suggested action:

No scores available.

Issue body

Tested locally in Snapcraft. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the addition of the craft_grammar_docs sub-package to the build system. Approved by two reviewers and cleared CI checks. The change updates four files with minimal build configuration adjustments.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 75
needs review Adds the craft_grammar_docs sub-package to the build configuration. Local lint and tests pass, but the changes have been inactive for 39 days with no comments. Awaiting review and merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#200 build(deps): update dependency craft-grammar to ~=2.1.0 imagecraft merged Merged dependency update for craft-grammar from ~=2.0.3 to ~=2.1.0. The lock file was initially missed but corrected after a retry. Approved by two reviewers and passed all CI checks.
75%
#202 build(deps): update internal packages imagecraft merged Merged automated dependency update. Upgraded craft-grammar to 2.2.0 and craft-parts to 2.21.0. Approved by two reviewers with all CI checks passing. Generated by Renovate.
75%
#5051 build(deps): bump craft-grammar to 2.0.1 snapcraft merged Merged after approval and CI checks. Bumped craft-grammar to 2.0.1 to fix model number coercion issues (#4978, #5017). Included craft-store 3.0.1 and craft-application updates per reviewer request to consolidate dependency bumps.
72%
#103 docs: update package documentation (CRAFT-37) craft-parts merged Merged documentation updates reorganizing the layout, improving docstrings, and adding lifecycle and class diagrams. Approved by two reviewers, passed CI, and changed 21 files (+511/-83).
71%
#2022 build(deps): update craft-parts charmcraft merged Merged to update the craft-parts dependency and fix the poetry plugin. Approved by two reviewers, passed CI, and applied a single-line change across one file.
71%
#1345 fix(docs): fix a typo craft-parts merged Merged a documentation fix addressing CRAFT_ARCH_BUILD_ON and CRAFT_ARCH_BUILD_FOR triplet differentiation. Approved by two reviewers with all CI checks passing.
71%
#1511 project_loader: support grammar on build-packages snapcraft merged Merged: Added grammar support for build-packages at part and global levels. Approved by one reviewer, passed CI, and modified 19 files. Builds on issue #1492 and depends on PR #1509.
70%
#9 docs: update build procedure and fix warning craft-store merged Merged updates consolidate API documentation configuration in conf.py for ReadTheDocs and fix a build warning. Approved by one reviewer, passed CI, and notes propagation to related craft-* projects.
70%
#401 build!: update to pydantic 2 craft-application merged Merged to update the codebase to Pydantic 2. Approved by two reviewers and passed CI. The change modified 23 files (+531/-342). Initial test failures were resolved after the craft-grammar dependency received a corresponding update.
70%